openstack/tempest
Code Issues Proposed changes

Merge "[Negative] Create a volume from deactivated image"

Browse Source
This commit is contained in:
Jenkins 2017-04-26 12:25:26 +00:00 committed by Gerrit Code Review
commit 93f2f81e58
1 changed files with 36 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
tempest/api/volume/test_volumes_negative.py
View File

@ -37,6 +37,25 @@ class VolumesNegativeTest(base.BaseVolumeTest):
cls.volume = cls.create_volume() cls.volume = cls.create_volume()
cls.mountpoint = "/dev/vdc" cls.mountpoint = "/dev/vdc"
def create_image(self):
# Create image
image_name = data_utils.rand_name(self.__class__.__name__ + "-image")
image = self.images_client.create_image(
name=image_name,
container_format=CONF.image.container_formats[0],
disk_format=CONF.image.disk_formats[0],
visibility='private',
min_disk=CONF.volume.volume_size + 1)
self.addCleanup(test_utils.call_and_ignore_notfound_exc,
self.images_client.delete_image, image['id'])
# Upload image with 1KB data
image_file = six.BytesIO(data_utils.random_bytes())
self.images_client.store_image_file(image['id'], image_file)
waiters.wait_for_image_status(self.images_client,
image['id'], 'active')
return image
@decorators.attr(type=['negative']) @decorators.attr(type=['negative'])
@decorators.idempotent_id('f131c586-9448-44a4-a8b0-54ca838aa43e') @decorators.idempotent_id('f131c586-9448-44a4-a8b0-54ca838aa43e')
def test_volume_get_nonexistent_volume_id(self): def test_volume_get_nonexistent_volume_id(self):
@ -276,21 +295,7 @@ class VolumesNegativeTest(base.BaseVolumeTest):
@test.services('image') @test.services('image')
def test_create_volume_from_image_with_decreasing_size(self): def test_create_volume_from_image_with_decreasing_size(self):
# Create image # Create image
image_name = data_utils.rand_name(self.__class__.__name__ + "-image") image = self.create_image()
image = self.images_client.create_image(
name=image_name,
container_format=CONF.image.container_formats[0],
disk_format=CONF.image.disk_formats[0],
visibility='private',
min_disk=CONF.volume.volume_size + 1)
self.addCleanup(test_utils.call_and_ignore_notfound_exc,
self.images_client.delete_image, image['id'])
# Upload image with 1KB data
image_file = six.BytesIO(data_utils.random_bytes())
self.images_client.store_image_file(image['id'], image_file)
waiters.wait_for_image_status(self.images_client,
image['id'], 'active')
# Note(jeremyZ): To shorten the test time (uploading a big size image # Note(jeremyZ): To shorten the test time (uploading a big size image
# is time-consuming), here just consider the scenario that volume size # is time-consuming), here just consider the scenario that volume size
@ -299,3 +304,19 @@ class VolumesNegativeTest(base.BaseVolumeTest):
self.volumes_client.create_volume, self.volumes_client.create_volume,
size=CONF.volume.volume_size, size=CONF.volume.volume_size,
imageRef=image['id']) imageRef=image['id'])
@decorators.attr(type=['negative'])
@decorators.idempotent_id('d15e7f35-2cfc-48c8-9418-c8223a89bcbb')
@test.services('image')
def test_create_volume_from_deactivated_image(self):
# Create image
image = self.create_image()
# Deactivate the image
self.images_client.deactivate_image(image['id'])
body = self.images_client.show_image(image['id'])
self.assertEqual("deactivated", body['status'])
# Try creating a volume from deactivated image
self.assertRaises(lib_exc.BadRequest,
self.create_volume,
imageRef=image['id'])