openstack/tempest
Code Issues Proposed changes

Verify os-migration API response attributes

Browse Source 
Now most attributes of Nova v2/v3 APIs are not checked in Tempest,
and this patch adds some tests which check these attributes to block
the backward incompatibility change in the future.

This patch adds the checks of v2/v3 os-migration API responses.

The response body of the API is the below:
 {
   "migrations": [
     {
       "id": 1,
       "status": "finished",
       "instance_uuid": "e9e4fdd7-f956-44ff-bfeb-d654a96ab3a2",
       "source_node": "localhost-dev",
       "source_compute": "localhost-dev",
       "dest_node": "localhost-dev",
       "dest_compute": "localhost-dev",
       "dest_host": "192.168.11.100",
       "old_instance_type_id": 6,
       "new_instance_type_id": 2,
       "created_at": "2014-03-18T00:14:49.000000",
       "updated_at": "2014-03-18T00:15:15.000000"
     }
   ]
 }

Partially implements blueprint nova-api-attribute-test

Change-Id: I21b7f55aa3310424f9c200c60a77e305af44cb48
This commit is contained in:
Ken'ichi Ohmichi 2014-04-08 22:31:17 +09:00
parent 7919447107
commit a7a14f127f
3 changed files with 63 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
tempest/api_schema/compute/migrations.py Normal file
View File

@ -0,0 +1,56 @@
# Copyright 2014 NEC Corporation. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
list_migrations = {
'status_code': [200],
'response_body': {
'type': 'object',
'properties': {
'migrations': {
'type': 'array',
'items': {
'type': 'object',
'properties': {
# NOTE: Now the type of 'id' is integer, but here
# allows 'string' also because we will be able to
# change it to 'uuid' in the future.
'id': {'type': ['integer', 'string']},
'status': {'type': 'string'},
'instance_uuid': {'type': 'string'},
'source_node': {'type': 'string'},
'source_compute': {'type': 'string'},
'dest_node': {'type': 'string'},
'dest_compute': {'type': 'string'},
'dest_host': {'type': 'string'},
'old_instance_type_id': {
'type': ['integer', 'string']
},
'new_instance_type_id': {
'type': ['integer', 'string']
},
'created_at': {'type': 'string'},
'updated_at': {'type': ['string', 'null']}
},
'required': [
'id', 'status', 'instance_uuid', 'source_node',
'source_compute', 'dest_node', 'dest_compute',
'dest_host', 'old_instance_type_id',
'new_instance_type_id', 'created_at', 'updated_at'
]
}
}
},
'required': ['migrations']
}
}

2
tempest/services/compute/json/migrations_client.py
View File

@ -15,6 +15,7 @@
import json
import urllib
from tempest.api_schema.compute import migrations as schema
from tempest.common import rest_client
from tempest import config
@ -36,4 +37,5 @@ class MigrationsClientJSON(rest_client.RestClient):
resp, body = self.get(url)
body = json.loads(body)
self.validate_response(schema.list_migrations, resp, body)
return resp, body['migrations']

6
tempest/services/compute/v3/json/migration_client.py
View File

@ -12,8 +12,10 @@
# License for the specific language governing permissions and limitations
# under the License.
import json
import urllib
from tempest.api_schema.compute import migrations as schema
from tempest.common import rest_client
from tempest import config
@ -34,4 +36,6 @@ class MigrationsV3ClientJSON(rest_client.RestClient):
url += '?%s' % urllib.urlencode(params)
resp, body = self.get(url)
return resp, self._parse_resp(body)
body = json.loads(body)
self.validate_response(schema.list_migrations, resp, body)
return resp, body['migrations']