openstack/tempest
Code Issues Proposed changes

Fixing tests when run_validation is set to true

Browse Source 
Many tempest tests don't work if the run_validation option is
set to true. The validation resources provider tries to create
security groups and security group rules for these tests and it
fails with the following error:

AttributeError: 'SecurityGroupsClient' object has no attribute
'create_security_group_rule'

The reason of failures is that we have recently separated the security
groups client into two clients: security groups client and security group
rules client. This patch fixes the issue.

Change-Id: I548e1fecb6698ac2609fd1581633170ceb638506
Closes-Bug: #1482669
This commit is contained in:
Yaroslav Lobankov 2015-08-07 17:30:51 +03:00
parent ea1a72ddb4
commit e5cc9fbbe3
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tempest/common/validation_resources.py
View File

@ -23,17 +23,17 @@ LOG = logging.getLogger(__name__)
def create_ssh_security_group(os, add_rule=False):
security_group_client = os.security_groups_client
security_groups_client = os.security_groups_client
security_group_rules_client = os.security_group_rules_client
sg_name = data_utils.rand_name('securitygroup-')
sg_description = data_utils.rand_name('description-')
security_group = \
security_group_client.create_security_group(name=sg_name,
description=sg_description)
security_group = security_groups_client.create_security_group(
name=sg_name, description=sg_description)
if add_rule:
security_group_client.create_security_group_rule(
security_group_rules_client.create_security_group_rule(
parent_group_id=security_group['id'], ip_protocol='tcp',
from_port=22, to_port=22)
security_group_client.create_security_group_rule(
security_group_rules_client.create_security_group_rule(
parent_group_id=security_group['id'], ip_protocol='icmp',
from_port=-1, to_port=-1)
LOG.debug("SSH Validation resource security group with tcp and icmp "