openstack
/
tempest
Code Issues Proposed changes

Adding missing test case of account generator resources 

Adding a new test which is missing from account generator resources.
Test name: test_generate_resources_swift_no_admin

This patch set will add the test to check generate resources when
Swift is enable but admin is not. It will also add some missing
checks in another tests.

Change-Id: I2b8991dd8aa20736d2b9f978a977fc227ed0ab8b
Partially-Implements: blueprint tempest-cli-unit-test-coverage
This commit is contained in:
Manik Bindlish 2018-10-01 09:01:46 +00:00
parent 469c53c3e2
commit ece4ae6e42
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tempest/tests/cmd/test_account_generator.py
View File

@ -106,6 +106,8 @@ class TestAccountGeneratorV2(base.TestCase, MockHelpersMixin):
cp = account_generator.get_credential_provider(self.opts)
admin_creds = cp.default_admin_creds
self.assertEqual(self.opts.os_tenant_name, admin_creds.tenant_name)
self.assertEqual(self.opts.os_username, admin_creds.username)
self.assertEqual(self.opts.os_password, admin_creds.password)
class TestAccountGeneratorV3(TestAccountGeneratorV2):
@ -222,6 +224,30 @@ class TestGenerateResourcesV2(base.TestCase, MockHelpersMixin):
self.assertIsNotNone(resource[1].router)
self.assertIsNotNone(resource[1].subnet)
def test_generate_resources_swift_no_admin(self):
cfg.CONF.set_default('swift', True, group='service_available')
cfg.CONF.set_default('operator_role', 'fake_operator',
group='object-storage')
cfg.CONF.set_default('reseller_admin_role', 'fake_reseller',
group='object-storage')
resources = account_generator.generate_resources(
self.cred_provider, admin=False)
resource_types = [k for k, _ in resources]
# No Admin, swift, expect four credentials only
self.assertEqual(4, len(resources))
# Ensure create_user was invoked 4 times (4 distinct users)
self.assertEqual(4, self.user_create_fixture.mock.call_count)
self.assertIn('primary', resource_types)
self.assertIn('alt', resource_types)
self.assertNotIn('admin', resource_types)
self.assertIn(['fake_operator'], resource_types)
self.assertIn(['fake_reseller'], resource_types)
self.assertNotIn(['fake_owner'], resource_types)
for resource in resources:
self.assertIsNotNone(resource[1].network)
self.assertIsNotNone(resource[1].router)
self.assertIsNotNone(resource[1].subnet)
class TestGenerateResourcesV3(TestGenerateResourcesV2):