openstack/tempest
Code Issues Proposed changes

Remove admin test_l3_agent_scheduler API test module

Browse Source 
Tests from this module are duplicated by same tests in
neutron-tempest-plugin repo.
Tests are in [1] module in this repo.

Both removed tests got 0% failure rate according to status.openstack.org
page.

It was discussed with QA PTL and he confirmed that those tests can
be removed from tempest. See [2] for details. Also ML thread about
this test removal notification[3].

[1] http://git.openstack.org/cgit/openstack/neutron-tempest-plugin/tree/neutron_tempest_plugin/api/admin/test_l3_agent_scheduler.py
[2] http://eavesdrop.openstack.org/irclogs/%23openstack-qa/%23openstack-qa.2019-03-01.log.html#t2019-03-01T16:18:32
[3] http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003574.html

Change-Id: I28f3bab54c25463d584db5398920d467a04bccf0
This commit is contained in:
Slawek Kaplonski 2019-03-04 14:47:07 +01:00 committed by Ghanshyam Mann
parent 155aee98ca
commit edcc172db3
1 changed files with 0 additions and 83 deletions

83
tempest/api/network/admin/test_l3_agent_scheduler.py

@ -1,83 +0,0 @@
# Copyright 2013 IBM Corp.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from tempest.api.network import base
from tempest.common import utils
from tempest.lib import decorators
from tempest.lib import exceptions
AGENT_TYPE = 'L3 agent'
AGENT_MODES = (
'legacy',
'dvr_snat'
)
class L3AgentSchedulerTestJSON(base.BaseAdminNetworkTest):
"""Tests the following operations in the Neutron API:
List routers that the given L3 agent is hosting.
List L3 agents hosting the given router.
Add and Remove Router to L3 agent
v2.0 of the Neutron API is assumed.
The l3_agent_scheduler extension is required for these tests.
"""
@classmethod
def skip_checks(cls):
super(L3AgentSchedulerTestJSON, cls).skip_checks()
if not utils.is_extension_enabled('l3_agent_scheduler', 'network'):
msg = "L3 Agent Scheduler Extension not enabled."
raise cls.skipException(msg)
@classmethod
def resource_setup(cls):
super(L3AgentSchedulerTestJSON, cls).resource_setup()
agents = cls.admin_agents_client.list_agents(
agent_type=AGENT_TYPE)['agents']
for agent in agents:
if (agent['configurations']['agent_mode'] in AGENT_MODES and
agent['alive']):
cls.agent = agent
break
else:
msg = "L3 Agent Scheduler enabled in conf, but L3 Agent not found"
raise exceptions.InvalidConfiguration(msg)
cls.router = cls.create_router()
@decorators.idempotent_id('b7ce6e89-e837-4ded-9b78-9ed3c9c6a45a')
def test_list_routers_on_l3_agent(self):
self.admin_agents_client.list_routers_on_l3_agent(self.agent['id'])
@decorators.idempotent_id('9464e5e7-8625-49c3-8fd1-89c52be59d66')
def test_add_list_remove_router_on_l3_agent(self):
l3_agent_ids = list()
self.admin_agents_client.create_router_on_l3_agent(
self.agent['id'],
router_id=self.router['id'])
body = (
self.admin_routers_client.list_l3_agents_hosting_router(
self.router['id']))
for agent in body['agents']:
l3_agent_ids.append(agent['id'])
self.assertIn('agent_type', agent)
self.assertEqual('L3 agent', agent['agent_type'])
self.assertIn(self.agent['id'], l3_agent_ids)
body = self.admin_agents_client.delete_router_from_l3_agent(
self.agent['id'],
self.router['id'])
# NOTE(afazekas): The deletion not asserted, because neutron
# is not forbidden to reschedule the router to the same agent