openstack/tempest
Code Issues Proposed changes

Fix fixed_ips tests to skip if ip not found

Browse Source 
Current fixed ips tests fetch the ip from server['addresses']
and call API with that ip. but it does not check if there is no
ip. That can occur when no addresses information in 'addresses'
field.

Let's skip those test if no ip is found on server side.

Change-Id: Ide965998b2d49886823e62643057c05698613169
This commit is contained in:
ghanshyam
2017-10-31 04:11:13 +00:00
parent 1d8dfec13d
commit f18ea3366c
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tempest/api/compute/admin/test_fixed_ips.py
View File

@@ -42,6 +42,7 @@ class FixedIPsTestJson(base.BaseV2ComputeAdminTest):
super(FixedIPsTestJson, cls).resource_setup()
server = cls.create_test_server(wait_until='ACTIVE')
server = cls.servers_client.show_server(server['id'])['server']
cls.ip = None
for ip_set in server['addresses']:
for ip in server['addresses'][ip_set]:
if ip['OS-EXT-IPS:type'] == 'fixed':
@@ -49,6 +50,9 @@ class FixedIPsTestJson(base.BaseV2ComputeAdminTest):
break
if cls.ip:
break
if cls.ip is None:
raise cls.skipException("No fixed ip found for server: %s"
% server['id'])
@decorators.idempotent_id('16b7d848-2f7c-4709-85a3-2dfb4576cc52')
def test_list_fixed_ip_details(self):

4
tempest/api/compute/admin/test_fixed_ips_negative.py
View File

@@ -43,6 +43,7 @@ class FixedIPsNegativeTestJson(base.BaseV2ComputeAdminTest):
super(FixedIPsNegativeTestJson, cls).resource_setup()
server = cls.create_test_server(wait_until='ACTIVE')
server = cls.servers_client.show_server(server['id'])['server']
cls.ip = None
for ip_set in server['addresses']:
for ip in server['addresses'][ip_set]:
if ip['OS-EXT-IPS:type'] == 'fixed':
@@ -50,6 +51,9 @@ class FixedIPsNegativeTestJson(base.BaseV2ComputeAdminTest):
break
if cls.ip:
break
if cls.ip is None:
raise cls.skipException("No fixed ip found for server: %s"
% server['id'])
@decorators.attr(type=['negative'])
@decorators.idempotent_id('9f17f47d-daad-4adc-986e-12370c93e407')