openstack/tempest
Code Issues Proposed changes

Reviewing guideline: ask for CRD when new test+feature flag

Browse Source 
To make sure that we don't accept new test that never gets executed.

Change-Id: I24435e575c9488c04a38e26719d5d4cfa29d7c27
This commit is contained in:
Jordan Pittier 2016-09-30 16:20:30 +02:00
parent 4db514cc01
commit f6a0b5e372
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
REVIEWING.rst
View File

@ -13,6 +13,13 @@ that the first thing to check with any change is that a gate job actually runs
it. Tests which aren't executed either because of configuration or skips should
not be accepted.
If a new test is added that depends on a new config option (like a feature
flag), the commit message must reference a change in DevStack or DevStack-Gate
that enables the execution of this newly introduced test. This reference could
either be a `Cross-Repository Dependency <http://docs.openstack.org/infra/
manual/developers.html#cross-repository-dependencies>`_ or a simple link
to a Gerrit review.
Unit Tests
----------