This commit introduces flake8-import-order to check import orders
automatically. We shouldn't do it manually.
Depends-On: Ia2140f5566ce169b076ffa5c9ebfbdbfc41e5bed
Change-Id: Iff75ebec42b295870edd1c04001adfb17460a682
exit() is used for interactive shell, it relies on the site module.
sys.exit() is considered good to use in programs.
Trivial-fix
Change-Id: I9e6e7a53581abefbb6cc3ba6ee6b853cd430d456
to keep Python 3.x compatibility, use six.StringIO/BytesIO to
replace StringIO.StringIO
StringIO works for unicode
BytesIO works for bytes
Change-Id: I063d62a4f005084f4088da403f348ad97656ad45
Partial-Bug: #1280100
We've recently changed default behaviour to forbid any dirty logs for
services outside the list instead of explicitly enabling log checks for
specific services. The comment was not updated to reflect the change
though.
Change-Id: I5d5ba64d156a9b5318cfc2740b2a69d75de3c127
The check logs script was not properly detecting grenade and would fail
grenade jobs if the logs were not clean. We don't want to do this
because the upgrade process is not log clean yet. Correct this by
setting grenade flag to true only if the DEVSTACK_GATE_GRENADE variable
has content.
Change-Id: Id8a339d78d981376b9af3a80aae8e4e18a68a85f
This commit changes the output of check_logs.py to be a bit more
concise and clear. Instead of printing out every instance of errors
found in the log files it will only print out which individual files
had errors. If a file is marked as not allowing ERRORS or TRACES it
also prints that along with the filename. This should hopefully avoid
confusion around the operation of this script running in the gate.
Change-Id: Ib2a9a9736470cd3b445fb51a95a1a6c6696bb2cc
After bumping the hacking version to the 0.9.x series ignores were
added for several rules. This commit fixes the violations for a subset
of these rules and re-enables the checks.
E123 is ignored because this rule is ignored in the default pep8 by
default, due to a lack of consensus around it.
Change-Id: I8f14cd2ca6afc38d3fe8ee758272071111022896
we've seen no n-sch errors in passing gate runs in the last week,
I consider this sufficient proof that we're clean on n-sch for now.
Part of bp:clean-logs
Change-Id: Ife0e0602767e155fc645e07546bed36c2c060a20
need to add this to the dirty list to make forward progress.
In order to make the results more readable we also need a line
break before the log file stanza.
Change-Id: I863a8a30384edf27a4ba761c707b5cf673c1f86e
instead of marking the logs that we think should be clean, mark
the ones we think should be dirty. This means no new services can
come in with unclean logs.
remove the whitelist data, as that's currently obsolete, we'll
remove the code for it later.
Change-Id: I4b15c932b78f54ec371aa67c7b4e8248b3f9c0eb
We don't need to have the vim headers in each source files. We can set
it in our vimrc file instead. Also if set incorrectly, gate (pep8 check)
will catch the mistakes.
More discussions:
http://lists.openstack.org/pipermail/openstack-dev/2013-October/017353.html
Change-Id: I43703e2289212389c7841f44691ae7849ed1f505
Closes-Bug: #1229324
because grenade is upgrading from old to new we might actually
expect the logs to be dirtier than in upstream tempest. The grenade
logs weren't scrubbed in the same ways during the development here
as the tempest regular runs.
Change-Id: Id1bcc2cc85e73a414d382756a65ea1d80dc10b00
Closes-Bug: #1259907
Because each project uses a slightly different format for logging, and
sometimes different formats within a project, it is hard to match ERROR as
the log level across all log files. There was a failure caused by "ERROR"
actually showing up inside a keystone token. This change will prevent that
though it is still possible something else could slip through.
Change-Id: Ic8b036b4ed7481856231b2d073d273b1df783415
The script will take a directory or url containing log files.
For now all non-whitelisted errors will be dumped to the console but
the script will always return success. Once we are convinced it is reliable
enough we can change it to fail on non-whitelisted errors.
Partially implements blueprint fail-gate-on-log-errors
Change-Id: I30b0eee1055f47aaad7984d886c739ccf5aa6186