This commit removes of the duplication of skip_tracker in
tempest/lib/cmd and tools. And we already have 'skip-tracker' command.
It comes from tempest/lib/cmd/skip_tracker.py, so I think we don't need
to have duplicated code. So we should deprecate it in tools directory.
This commit also add a default test_path value for convenience and
compatibility.
Change-Id: I43a0a9d115e59c860714a47aea11017e8b58b5e7
Looping over the .keys() method of a dictionary is an anti-pattern. In
fact, the method is actually creating a new list which is redundant and
unnecessary. Looping over a dictionary implicitly loops over its keys.
Change-Id: I937d3f060bf95bb86e50fcb5dec8def524f6208e
There is a lot of H404/405 violations in Tempest now, and that leads
difficult to migrate the code to tempest-lib or the other projects'
repos. This patch fixes these violations for tools for enabling
H404/405 rules on Tempest.
Change-Id: I4e1d78532d8f96edd5fd28a7bd2d62181fe9144b
We don't need to have the vim headers in each source files. We can set
it in our vimrc file instead. Also if set incorrectly, gate (pep8 check)
will catch the mistakes.
More discussions:
http://lists.openstack.org/pipermail/openstack-dev/2013-October/017353.html
Change-Id: I43703e2289212389c7841f44691ae7849ed1f505
Closes-Bug: #1229324
This commit adds support for also printing the filenames along with
the bug number in the skip tracker output. This should make it
slightly easier to find the skips and remove them.
Change-Id: Ia3502f1a48bb9e028d046fa60307e398582e6124
this change introduces a skip_because decorator which accepts two args
a bug and a condition; also updates the skip tracker accordingly
Change-Id: If53f2ef81d6bddbce284267216254b467046855f
Some files still use trademark OpenStack LLC in header, which
should be changed to OpenStack Foundation.
NOTE: tools/install_venv.py is not synced from oslo-incubator, so
it is modified too.
Change-Id: I0084684ff5225076291fea857eb010d638291bd0
Fixes-Bug: #1214176
This commit changes the regex used for detecting a skip line by
removing the requirement on an '(' immediately following 'skip'.
This changes the skip tracker to match multiline skips (assuming
'skip' is on the same line as the bug number. It also enables
conditional skips that have a bug number from being picked up.
Change-Id: I95a0521661084034f7625c3c517ae9210120de4c
This commit changes the regex for detecting a bug in
skip_tracker.py to be case insensitive and support a colon
instead of whitespace immediately following the bug keyword.
Previously only Bug or bug was detected, and whitespace needed
to follow the bug keyword for skip_tracker.py to pick up the bug
number correctly. This causes issues with some skips because they
didn't comply with these constraints. This commit fixes these issues
by allow any capitalization of 'bug' and allowing either a colon or
whitespace to immediately follow the bug keyword.
Change-Id: I0e9a073b195d475e0b1eebc76e4db160742e171e
Previously, if a tempest test was skipped because of a bug that
was marked a duplicate of another bug the skip tracker would not
check the status of the duplicate bug. This would cause fixed bugs
from being shown up in the list, because the original bug's status
is not necessarily updated if it is marked as a duplicate.
This commit fixes this behavior by checking if there is a duplicate
bug first. Then after all the bugs' statuses are checked the list of
duplicate bugs is checked. If a duplicate bug is marked as fixed the
original bug is added to list of bugs that is safe to unskip.
Change-Id: Ia1aaec9e01a97556d17b0640a95e03f0f0b37680
The list server filter details checks were checking
entire mappings against the list of mappings returned
from a call to GET /servers/detail. Unfortunately, the
mappings returned by the GET /servers/detail and the
mapping returned by POST /servers are slightly different,
resulting in the comparison failing. We really only are
checking that the server instance we expect to be in the
returned list of instances is there, so checking for the
server ID in the returned list is fine.
Change-Id: If9680f56a1ea06ffe93393d06b23bd231ccddd01
Fixes: LP Bug 1028465pep8 build for tempest.