![Matthew Treinish](/assets/img/avatar_default.png)
This commit fixes the HTTP GET call to return the list of nova api versions. The enpoint that the tempest clients use for servers includes the api version. This is because nova registers each version api as separate endpoints in keystone's catalog. So this commit fixes the url to use the unversioned endpoint so the list of versions will be returned. Change-Id: Iaf4671d4d1dd285161aa5679648956c086a9119c
159 lines
5.8 KiB
Python
Executable File
159 lines
5.8 KiB
Python
Executable File
#!/usr/bin/env python
|
|
|
|
# Copyright 2013 IBM Corp.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import json
|
|
import sys
|
|
|
|
import httplib2
|
|
|
|
from tempest import clients
|
|
from tempest import config
|
|
|
|
|
|
CONF = config.CONF
|
|
RAW_HTTP = httplib2.Http()
|
|
|
|
|
|
def verify_glance_api_versions(os):
|
|
# Check glance api versions
|
|
__, versions = os.image_client.get_versions()
|
|
if CONF.image_feature_enabled.api_v1 != ('v1.1' in versions or 'v1.0' in
|
|
versions):
|
|
print('Config option image api_v1 should be change to: %s' % (
|
|
not CONF.image_feature_enabled.api_v1))
|
|
if CONF.image_feature_enabled.api_v2 != ('v2.0' in versions):
|
|
print('Config option image api_v2 should be change to: %s' % (
|
|
not CONF.image_feature_enabled.api_v2))
|
|
|
|
|
|
def verify_nova_api_versions(os):
|
|
# Check nova api versions - only get base URL without PATH
|
|
os.servers_client.skip_path = True
|
|
# The nova base endpoint url includes the version but to get the versions
|
|
# list the unversioned endpoint is needed
|
|
v2_endpoint = os.servers_client.base_url
|
|
v2_endpoint_parts = v2_endpoint.split('/')
|
|
endpoint = v2_endpoint_parts[0] + '//' + v2_endpoint_parts[2]
|
|
__, body = RAW_HTTP.request(endpoint, 'GET')
|
|
body = json.loads(body)
|
|
# Restore full base_url
|
|
os.servers_client.skip_path = False
|
|
versions = map(lambda x: x['id'], body['versions'])
|
|
if CONF.compute_feature_enabled.api_v3 != ('v3.0' in versions):
|
|
print('Config option compute api_v3 should be change to: %s' % (
|
|
not CONF.compute_feature_enabled.api_v3))
|
|
|
|
|
|
def get_extension_client(os, service):
|
|
extensions_client = {
|
|
'nova': os.extensions_client,
|
|
'nova_v3': os.extensions_v3_client,
|
|
'cinder': os.volumes_extension_client,
|
|
'neutron': os.network_client,
|
|
}
|
|
if service not in extensions_client:
|
|
print('No tempest extensions client for %s' % service)
|
|
exit(1)
|
|
return extensions_client[service]
|
|
|
|
|
|
def get_enabled_extensions(service):
|
|
extensions_options = {
|
|
'nova': CONF.compute_feature_enabled.api_extensions,
|
|
'nova_v3': CONF.compute_feature_enabled.api_v3_extensions,
|
|
'cinder': CONF.volume_feature_enabled.api_extensions,
|
|
'neutron': CONF.network_feature_enabled.api_extensions,
|
|
}
|
|
if service not in extensions_options:
|
|
print('No supported extensions list option for %s' % service)
|
|
exit(1)
|
|
return extensions_options[service]
|
|
|
|
|
|
def verify_extensions(os, service, results):
|
|
extensions_client = get_extension_client(os, service)
|
|
__, resp = extensions_client.list_extensions()
|
|
if isinstance(resp, dict):
|
|
# Neutron's extension 'name' field has is not a single word (it has
|
|
# spaces in the string) Since that can't be used for list option the
|
|
# api_extension option in the network-feature-enabled group uses alias
|
|
# instead of name.
|
|
if service == 'neutron':
|
|
extensions = map(lambda x: x['alias'], resp['extensions'])
|
|
else:
|
|
extensions = map(lambda x: x['name'], resp['extensions'])
|
|
|
|
else:
|
|
extensions = map(lambda x: x['name'], resp)
|
|
if not results.get(service):
|
|
results[service] = {}
|
|
extensions_opt = get_enabled_extensions(service)
|
|
if extensions_opt[0] == 'all':
|
|
results[service]['extensions'] = 'all'
|
|
return results
|
|
# Verify that all configured extensions are actually enabled
|
|
for extension in extensions_opt:
|
|
results[service][extension] = extension in extensions
|
|
# Verify that there aren't additional extensions enabled that aren't
|
|
# specified in the config list
|
|
for extension in extensions:
|
|
if extension not in extensions_opt:
|
|
results[service][extension] = False
|
|
return results
|
|
|
|
|
|
def display_results(results):
|
|
for service in results:
|
|
# If all extensions are specified as being enabled there is no way to
|
|
# verify this so we just assume this to be true
|
|
if results[service].get('extensions'):
|
|
continue
|
|
extension_list = get_enabled_extensions(service)
|
|
for extension in results[service]:
|
|
if not results[service][extension]:
|
|
if extension in extension_list:
|
|
print("%s extension: %s should not be included in the list"
|
|
" of enabled extensions" % (service, extension))
|
|
else:
|
|
print("%s extension: %s should be included in the list of "
|
|
"enabled extensions" % (service, extension))
|
|
|
|
|
|
def check_service_availability(service):
|
|
if service == 'nova_v3':
|
|
service = 'nova'
|
|
return getattr(CONF.service_available, service)
|
|
|
|
|
|
def main(argv):
|
|
print('Running config verification...')
|
|
os = clients.ComputeAdminManager(interface='json')
|
|
results = {}
|
|
for service in ['nova', 'nova_v3', 'cinder', 'neutron']:
|
|
# TODO(mtreinish) make this a keystone endpoint check for available
|
|
# services
|
|
if not check_service_availability(service):
|
|
print("%s is not available" % service)
|
|
continue
|
|
results = verify_extensions(os, service, results)
|
|
verify_glance_api_versions(os)
|
|
verify_nova_api_versions(os)
|
|
display_results(results)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main(sys.argv)
|