Fix ansible lint and ubuntu deployment

This patch combines two different fixes, since both are required to get
CI tests passing.

1. Fix ansible lint 301 with ip link set dev <device> up

This resolves:

[301] Commands should not change things if nothing needs doing
/home/will/code/tenks/ansible/roles/veth-pair/tasks/present.yml:13
Task/Handler: Bring each end of veth up

ip link set dev <device> up is idempotent:

707f612c00/ip/iplink.c (L264)
63bdf4284c/net/core/rtnetlink.c (L2485)
63bdf4284c/net/core/dev.c (L7632)
63bdf4284c/net/core/dev.c (L7563)

2. Add pkg-config as an explicit dependency

This is to fix the following error:

Exception: pkg-config binary is required to compile libvirt-python

TrivialFix

Change-Id: I9a2db7b5f2cbdcb64227bd4f1de245bcb7f71f5b

ansible/roles/veth-pair/tasks/present.yml

@@ -16,6 +16,9 @@
     - "{{ veth_pair_ovs_link_name }}"
     - "{{ veth_pair_source_link_name }}"
   become: true
+  # if the interface is already up, this ultimately ends up being a noop, see:
+  # https://github.com/torvalds/linux/blob/63bdf4284c38a48af21745ceb148a087b190cd21/net/core/dev.c#L7563
+  changed_when: false
 
 - name: Plug veth into OVS bridge
   openvswitch_port:

ansible/roles/virtualbmc-daemon/vars/Debian.yml

@@ -3,3 +3,4 @@
 vbmcd_packages:
   - gcc
   - libvirt-dev
+  - pkg-config

ansible/roles/virtualbmc-daemon/vars/RedHat.yml

@@ -2,4 +2,5 @@
 # List of package dependencies to install.
 vbmcd_packages:
   - gcc
+  - pkgconfig
   - libvirt-devel