openstack
/
tooz
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: (3 inline comments)



Patch-set: 1
Label: Code-Review=0
This commit is contained in:
Gerrit User 8122 2013-12-09 10:51:42 +00:00 committed by Gerrit Code Review
parent 3ee35ede2c
commit 014b39545d
1 changed files with 51 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
62e0248f00d4b07314d824a9711d8e045ea22e98
View File

@ -85,6 +85,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pWs\u003d",
"filename": "README.rst",
"patchSetId": 1
},
"lineNbr": 4,
"author": {
"id": 8122
},
"writtenOn": "2013-12-09T10:51:42Z",
"side": 1,
"message": "developer, with a single \u0027p\u0027.",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9snk\u003d",
@ -136,6 +153,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pWc\u003d",
"filename": "setup.py",
"patchSetId": 1
},
"lineNbr": 22,
"author": {
"id": 8122
},
"writtenOn": "2013-12-09T10:51:42Z",
"side": 1,
"message": "This is a dirty hack needed when you\u0027re not inside a git repository and using pbr. Could you remove it ?",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vzo\u003d",
@ -359,6 +393,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pV8\u003d",
"filename": "tooz/api.py",
"patchSetId": 1
},
"lineNbr": 95,
"author": {
"id": 8122
},
"writtenOn": "2013-12-09T10:51:42Z",
"side": 1,
"message": "+1. Either remove it, or raise NotImplementedError.",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vyE\u003d",