openstack
/
tooz
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: (11 inline comments)



Patch-set: 2
Label: Code-Review=0
Label: Workflow=0
This commit is contained in:
Gerrit User 7450 2013-12-09 14:12:50 +00:00 committed by Gerrit Code Review
parent e66bd648d7
commit 25c1314310
1 changed files with 198 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

198
db1708709fc5c9685eb443cd70f0ec798f0f487b
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9o3A\u003d",
"filename": ".gitignore",
"patchSetId": 2
},
"lineNbr": 20,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "Done",
"parentUuid": "AAAATn/9pEg\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pEw\u003d",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9ogM\u003d",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 24,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "Done",
"parentUuid": "AAAATn/9pEw\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pD8\u003d",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9o2A\u003d",
"filename": "README.rst",
"patchSetId": 2
},
"lineNbr": 4,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "Done",
"parentUuid": "AAAATn/9pD8\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pDo\u003d",
@ -68,6 +122,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9o1g\u003d",
"filename": "setup.cfg",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "Done",
"parentUuid": "AAAATn/9pDo\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pDg\u003d",
@ -103,6 +175,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9oyc\u003d",
"filename": "setup.py",
"patchSetId": 2
},
"lineNbr": 2,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "This come from openstack/requirements.",
"parentUuid": "AAAATn/9pDg\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pDY\u003d",
@ -137,6 +227,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9oxE\u003d",
"filename": "tooz/api.py",
"patchSetId": 2
},
"lineNbr": 53,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "I prefer to use sphinx\u0027s conventions.",
"parentUuid": "AAAATn/9pDM\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pC8\u003d",
@ -154,6 +262,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9ows\u003d",
"filename": "tooz/api.py",
"patchSetId": 2
},
"lineNbr": 84,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "The list.",
"parentUuid": "AAAATn/9pC8\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pCY\u003d",
@ -171,6 +297,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9ovo\u003d",
"filename": "tooz/api.py",
"patchSetId": 2
},
"lineNbr": 114,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "Yes, please read the comment above, i would like to change it.",
"parentUuid": "AAAATn/9pCY\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pCU\u003d",
@ -188,6 +332,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9os4\u003d",
"filename": "tooz/drivers/zookeeper.py",
"patchSetId": 2
},
"lineNbr": 30,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "Done",
"parentUuid": "AAAATn/9pCU\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pB4\u003d",
@ -205,6 +367,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9opY\u003d",
"filename": "tooz/drivers/zookeeper.py",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "No, thanks :) !",
"parentUuid": "AAAATn/9pB4\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9pB0\u003d",
@ -221,6 +401,24 @@
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9op4\u003d",
"filename": "tooz/tests/test_api.py",
"patchSetId": 2
},
"lineNbr": 30,
"author": {
"id": 7450
},
"writtenOn": "2013-12-09T14:12:50Z",
"side": 1,
"message": "Yes i need the most feedbacks. For now, you can run a local zookeeper and run the tests before we automate it in the CI.",
"parentUuid": "AAAATn/9pB0\u003d",
"revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}