openstack
/
tooz
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: I would prefer that you didn't merge this

(14 inline comments)

Great to see this moving forward!

Patch-set: 1
Reviewer: Gerrit User 688 <688@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 688 2013-12-06 19:51:26 +00:00 committed by Gerrit Code Review
parent 0e444af86d
commit 53c29b3c26
1 changed files with 240 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

240
62e0248f00d4b07314d824a9711d8e045ea22e98
View File

@ -51,6 +51,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9t4g\u003d",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "Perhaps this should go in the Readme?",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9v04\u003d",
@ -68,6 +85,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9t3w\u003d",
"filename": "setup.cfg",
"patchSetId": 1
},
"lineNbr": 3,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "developers",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vug\u003d",
@ -136,6 +170,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9t24\u003d",
"filename": "tooz/api.py",
"patchSetId": 1
},
"lineNbr": 27,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "I think this is fine as the namespace handled the descriptive part. \n\nThough, perhaps consider bringing this into the __init__ file so we can do tooz.API vs. tooz.api.API",
"parentUuid": "AAAATn/9v0E\u003d",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vyw\u003d",
@ -153,6 +205,41 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9t2k\u003d",
"filename": "tooz/api.py",
"patchSetId": 1
},
"lineNbr": 31,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "or consider passing in a config dictionary (not oslo, keep it simple).",
"parentUuid": "AAAATn/9vyw\u003d",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9t2c\u003d",
"filename": "tooz/api.py",
"patchSetId": 1
},
"lineNbr": 36,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "use python docstrings for parameter descriptions",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9v0c\u003d",
@ -204,6 +291,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9t2I\u003d",
"filename": "tooz/api.py",
"patchSetId": 1
},
"lineNbr": 94,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "no dead code",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vyE\u003d",
@ -221,6 +325,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9t2A\u003d",
"filename": "tooz/api.py",
"patchSetId": 1
},
"lineNbr": 138,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "no dead code",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vz0\u003d",
@ -272,6 +393,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9t1c\u003d",
"filename": "tooz/drivers/zookeeper.py",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "import modules not classes",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vwE\u003d",
@ -357,6 +495,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9t0o\u003d",
"filename": "tooz/drivers/zookeeper.py",
"patchSetId": 1
},
"lineNbr": 61,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "do we want Zookeeper exceptions getting through to the caller? Should we wrap these in Tooz-consistent exceptions?",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vus\u003d",
@ -460,6 +615,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9tzc\u003d",
"filename": "tooz/exceptions.py",
"patchSetId": 1
},
"lineNbr": 27,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "don\u0027t need to override if you\u0027re not changing anything.",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vs8\u003d",
@ -477,6 +649,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9tzM\u003d",
"filename": "tooz/models.py",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "\"The member of a group.\" perhaps?",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vzU\u003d",
@ -512,6 +701,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9tyc\u003d",
"filename": "tooz/models.py",
"patchSetId": 1
},
"lineNbr": 26,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "an example of capabilities would be useful:\n\nis it like \"fast, no_replication, unicode\"? Would a richer data structure be more useful? Do we care about the data structure at all? Can it just be a \"thing\"?",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vzQ\u003d",
@ -564,6 +770,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9tyY\u003d",
"filename": "tooz/tests/test_api.py",
"patchSetId": 1
},
"lineNbr": 20,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "import module, not class",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vpY\u003d",
@ -581,6 +804,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9txw\u003d",
"filename": "tooz/tests/test_api.py",
"patchSetId": 1
},
"lineNbr": 24,
"author": {
"id": 688
},
"writtenOn": "2013-12-06T19:51:26Z",
"side": 1,
"message": "This is an integration test. We should be very strict on not mixing integration with unit tests. A FakeDriver would be a good start.",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vpM\u003d",