Update patch set 2
Patch Set 2: (1 inline comment) Patch-set: 2 Label: Code-Review=0
This commit is contained in:
parent
7e7b48f0e8
commit
59cdc878c5
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAUH/9prM\u003d",
|
||||
"filename": "tooz/utils.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 27,
|
||||
"author": {
|
||||
"id": 9107
|
||||
},
|
||||
"writtenOn": "2014-02-05T10:42:44Z",
|
||||
"side": 1,
|
||||
"message": "Such function should be in Oslo Incubator if we decide to use it.\n\nOn Python 2, it returns a different type on error, it can lead to bugs in error handling. You should always return the same type (text string). If text_type(exc) fails, try str(exc).decode(\u0027utf-8\u0027), or fallback to str(exc).decode(\u0027latin-1\u0027).",
|
||||
"revId": "b0d8733298486fa2d8a984a4ab2000993a48c24f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue