Update patch set 2
Patch Set 2: I would prefer that you didn't merge this (1 inline comment) Thanks Joshua for this patch, I like the idea but i think it would be better to put in place only one general callback for the connection loss because in case of a KazooState.LOST event then the membership is lost for all joined groups and not only the ones on which a callback has been registred. Patch-set: 2 Label: Code-Review=-1
This commit is contained in:
parent
8c9189361e
commit
92d03dff97
|
@ -0,0 +1,21 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "AAAAUH/9ocE\u003d",
|
||||||
|
"filename": "tooz/drivers/zookeeper.py",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 103,
|
||||||
|
"author": {
|
||||||
|
"id": 7450
|
||||||
|
},
|
||||||
|
"writtenOn": "2014-02-05T14:29:29Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Could you please rebase on master, _wrap_kazoo_call is no longer used.",
|
||||||
|
"revId": "3556883f16d9d58967bee7b2ab45f8c740a80471",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue