Update patch set 2

Patch Set 2: (12 inline comments) Patch-set: 2 Reviewer: Gerrit User 8122 <8122@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=0 Label: Workflow=0
2013-12-09 12:17:37 +00:00 · 2013-12-09 12:17:37 +00:00 · ae093f98d1
parent 4b22472d3c
commit ae093f98d1
1 changed files with 208 additions and 0 deletions
--- a/208
+++ b/208
@ -0,0 +1,208 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "AAAATn/9pEg\u003d",
+        "filename": ".gitignore",
+        "patchSetId": 2
+      },
+      "lineNbr": 20,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "There is no doc/ repository. Why would you ignore it ? The same thing is probably true for other files.",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pEw\u003d",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 2
+      },
+      "lineNbr": 24,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "I don\u0027t think this listing should be in the commit log. An English message describing what has been done would be better.",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pD8\u003d",
+        "filename": "README.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 4,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "Here, I\u0027d say \"aim at centralizing\".",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pDo\u003d",
+        "filename": "setup.cfg",
+        "patchSetId": 2
+      },
+      "lineNbr": 14,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "You should probably add:\n\nProgramming Language :: Python :: 2.7\n\nAnd all supported versions of Python.",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pDg\u003d",
+        "filename": "setup.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 2,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "I don\u0027t think so.",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pDY\u003d",
+        "filename": "tooz/api.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 3,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "I really hate those. Not sure what the officiel OpenStack policy is, though.",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pDM\u003d",
+        "filename": "tooz/api.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 53,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "Do we really want to have \":param\" and \":type\" ? I\u0027d rather have:\n\n\":param group_id: a string representing the id of the group to create.\"\n\nor something similar.",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pC8\u003d",
+        "filename": "tooz/api.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 84,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "Do we want the list or a generator ?",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pCY\u003d",
+        "filename": "tooz/api.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 114,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "\"kwargs\" is weird, since we are used to reading \"**kwargs\", don\u0027t you think ?",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pCU\u003d",
+        "filename": "tooz/drivers/zookeeper.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 30,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "contain*",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pB4\u003d",
+        "filename": "tooz/drivers/zookeeper.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 33,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "Is \"kwargs[\"hosts\"] and member_id\" an iterable ?",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "AAAATn/9pB0\u003d",
+        "filename": "tooz/tests/test_api.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 30,
+      "author": {
+        "id": 8122
+      },
+      "writtenOn": "2013-12-09T12:17:37Z",
+      "side": 1,
+      "message": "These tests are not run yet, should we add them ?",
+      "revId": "db1708709fc5c9685eb443cd70f0ec798f0f487b",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}