Update patch set 1

Patch Set 1: (2 inline comments)

A few more comments :-)

Patch-set: 1
This commit is contained in:
Gerrit User 1297 2013-12-07 01:52:03 +00:00 committed by Gerrit Code Review
parent 423eae9b79
commit c73ec92abb
1 changed files with 35 additions and 0 deletions

View File

@ -461,6 +461,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9st8\u003d",
"filename": "tooz/drivers/zookeeper.py",
"patchSetId": 1
},
"lineNbr": 26,
"author": {
"id": 1297
},
"writtenOn": "2013-12-07T01:52:03Z",
"side": 1,
"message": "From what I understand there is a way to use it in a async style.\n\nBut its not in the style of http://docs.python.org/dev/library/concurrent.futures.html#future-objects (which is where the python community seems to be headed). But it seems like this driver could return futures that wrap how kazoo supports asynchronous activities if this is desired.\n\nSee: https://github.com/python-zk/kazoo/blob/master/kazoo/client.py#L933 (get_async as an example).\n\nSee the below handler client option (and associated comment) that can be passed into the client can alleviate this; use a gevent, eventlet, other non-blocking handler.",
"parentUuid": "AAAATn/9vwE\u003d",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vuY\u003d",
@ -495,6 +513,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9suk\u003d",
"filename": "tooz/drivers/zookeeper.py",
"patchSetId": 1
},
"lineNbr": 33,
"author": {
"id": 1297
},
"writtenOn": "2013-12-07T01:52:03Z",
"side": 1,
"message": "U probably also want to allow a \u0027handler\u0027 to be provided here. The following package (not in kazoo at the moment) allows for better usage of eventlet in kazoo (via passing in a different handler). Its also useful in non-eventlet cases (where someone may want to use the gevent handler, or a new XYZ handler). That handler is pretty extensively used inside kazoo for event handling so allowing it to be passed in will mean this driver can be used in more environment types.\n\nSee: https://pypi.python.org/pypi/kazoo-eventlet-handler\n\nSee: https://github.com/python-zk/kazoo/blob/master/kazoo/client.py#L115",
"revId": "62e0248f00d4b07314d824a9711d8e045ea22e98",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn/9vzk\u003d",