133 lines
3.9 KiB
Plaintext
133 lines
3.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "24f50a04_01cce592",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 32553
|
|
},
|
|
"writtenOn": "2024-03-07T09:04:53Z",
|
|
"side": 1,
|
|
"message": "do you mean https://review.opendev.org/c/openstack/tooz/+/907659 ?\nbecause this ID also points to the commit fixing itself?",
|
|
"range": {
|
|
"startLine": 14,
|
|
"startChar": 0,
|
|
"endLine": 14,
|
|
"endChar": 2
|
|
},
|
|
"revId": "94d299c77736dafb9eadb80f080aec3d974d3edf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "59a3be09_18455b3c",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2024-03-07T09:32:31Z",
|
|
"side": 1,
|
|
"message": "Yes. I usually use commit id instead of gerrit id in commit message because commit id can be looked up locally...",
|
|
"parentUuid": "24f50a04_01cce592",
|
|
"range": {
|
|
"startLine": 14,
|
|
"startChar": 0,
|
|
"endLine": 14,
|
|
"endChar": 2
|
|
},
|
|
"revId": "94d299c77736dafb9eadb80f080aec3d974d3edf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "54ddd1e7_42590f35",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2024-03-07T08:46:14Z",
|
|
"side": 1,
|
|
"message": "can this be tested somehow other than making a release and running it in kolla?",
|
|
"revId": "94d299c77736dafb9eadb80f080aec3d974d3edf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c5bea9a6_61853261",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2024-03-07T09:24:42Z",
|
|
"side": 1,
|
|
"message": "We have to dig into the current functional tests to find out why functional tests with redis sentinel didn\u0027t caught the problem but it may take some time. tooz is known to have very low unit test coverage so adding unit tests may still take some time.\n\nFor now I reproduced the problem in my local with tooz 6.0.0 and confirmed that this change resolves the problem.",
|
|
"parentUuid": "54ddd1e7_42590f35",
|
|
"revId": "94d299c77736dafb9eadb80f080aec3d974d3edf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "681347a9_81a66f5a",
|
|
"filename": "tooz/drivers/redis.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 477,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2024-03-07T08:46:14Z",
|
|
"side": 1,
|
|
"message": "this seems duplicate of the loop above and doesn\u0027t make sense to me",
|
|
"range": {
|
|
"startLine": 476,
|
|
"startChar": 12,
|
|
"endLine": 477,
|
|
"endChar": 68
|
|
},
|
|
"revId": "94d299c77736dafb9eadb80f080aec3d974d3edf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d46f8587_b8c1e100",
|
|
"filename": "tooz/drivers/redis.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 477,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2024-03-07T08:53:57Z",
|
|
"side": 1,
|
|
"message": "Sorry I pulled a change for different topic. Dropped it.",
|
|
"parentUuid": "681347a9_81a66f5a",
|
|
"range": {
|
|
"startLine": 476,
|
|
"startChar": 12,
|
|
"endLine": 477,
|
|
"endChar": 68
|
|
},
|
|
"revId": "94d299c77736dafb9eadb80f080aec3d974d3edf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |