67 lines
2.0 KiB
Plaintext
67 lines
2.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "efe591a8_268be5fa",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2024-02-05T02:30:00Z",
|
|
"side": 1,
|
|
"message": "This also needs a release note.",
|
|
"revId": "ba3a7531467418387b26f6bc0794b59728b02172",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f6ce4a12_0bcde37b",
|
|
"filename": "tooz/drivers/memcached.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 218,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2024-02-05T02:30:00Z",
|
|
"side": 1,
|
|
"message": "why is this sentinel ? sentinel is specific to redis.\n\nThis is not aligned with L212 (extra_host)",
|
|
"range": {
|
|
"startLine": 218,
|
|
"startChar": 34,
|
|
"endLine": 218,
|
|
"endChar": 42
|
|
},
|
|
"revId": "ba3a7531467418387b26f6bc0794b59728b02172",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4a238b22_dee8f914",
|
|
"filename": "tooz/drivers/memcached.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 284,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2024-02-05T02:30:00Z",
|
|
"side": 1,
|
|
"message": "pymemcache has own implementation of cluster support. Use it instead of implementing the same in this layer. Probably you can replace PooledClient by HashClient (with a few adjustments of arguments).\n\nhttps://pymemcache.readthedocs.io/en/latest/apidoc/pymemcache.client.hash.html#module-pymemcache.client.hash",
|
|
"range": {
|
|
"startLine": 283,
|
|
"startChar": 8,
|
|
"endLine": 284,
|
|
"endChar": 1
|
|
},
|
|
"revId": "ba3a7531467418387b26f6bc0794b59728b02172",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |