tooz/ba3a7531467418387b26f6bc0794b59728b02172

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "efe591a8_268be5fa",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 6
      },
      "lineNbr": 0,
      "author": {
        "id": 9816
      },
      "writtenOn": "2024-02-05T02:30:00Z",
      "side": 1,
      "message": "This also needs a release note.",
      "revId": "ba3a7531467418387b26f6bc0794b59728b02172",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "b719243c_6c9d25b3",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 6
      },
      "lineNbr": 0,
      "author": {
        "id": 36759
      },
      "writtenOn": "2024-02-06T02:26:28Z",
      "side": 1,
      "message": "release note added",
      "parentUuid": "efe591a8_268be5fa",
      "revId": "ba3a7531467418387b26f6bc0794b59728b02172",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f6ce4a12_0bcde37b",
        "filename": "tooz/drivers/memcached.py",
        "patchSetId": 6
      },
      "lineNbr": 218,
      "author": {
        "id": 9816
      },
      "writtenOn": "2024-02-05T02:30:00Z",
      "side": 1,
      "message": "why is this sentinel  ? sentinel is specific to redis.\n\nThis is not aligned with L212 (extra_host)",
      "range": {
        "startLine": 218,
        "startChar": 34,
        "endLine": 218,
        "endChar": 42
      },
      "revId": "ba3a7531467418387b26f6bc0794b59728b02172",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "13c49ba1_5fd750b0",
        "filename": "tooz/drivers/memcached.py",
        "patchSetId": 6
      },
      "lineNbr": 218,
      "author": {
        "id": 9816
      },
      "writtenOn": "2024-02-05T02:34:24Z",
      "side": 1,
      "message": "Also, see how sentinel_fallback is implemented in the redis driver and align how this is implemented with that.\n\nAlso, the name \"host\" is confusing if it contains host:port. \"server\" would be a better worning\n\nwhy I may suggest is\n\nmemcached://\u003chost\u003e:\u003cport\u003e?extra_server\u003d\u003chost\u003e:\u003cport\u003e\u0026extra_server\u003d\u003chost\u003e:\u003cport\u003e",
      "parentUuid": "f6ce4a12_0bcde37b",
      "range": {
        "startLine": 218,
        "startChar": 34,
        "endLine": 218,
        "endChar": 42
      },
      "revId": "ba3a7531467418387b26f6bc0794b59728b02172",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e6993a2e_d87f0e09",
        "filename": "tooz/drivers/memcached.py",
        "patchSetId": 6
      },
      "lineNbr": 218,
      "author": {
        "id": 36759
      },
      "writtenOn": "2024-02-06T02:25:31Z",
      "side": 1,
      "message": "thanks for your advice, the arguments have been renamed",
      "parentUuid": "13c49ba1_5fd750b0",
      "range": {
        "startLine": 218,
        "startChar": 34,
        "endLine": 218,
        "endChar": 42
      },
      "revId": "ba3a7531467418387b26f6bc0794b59728b02172",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "4a238b22_dee8f914",
        "filename": "tooz/drivers/memcached.py",
        "patchSetId": 6
      },
      "lineNbr": 284,
      "author": {
        "id": 9816
      },
      "writtenOn": "2024-02-05T02:30:00Z",
      "side": 1,
      "message": "pymemcache has own implementation of cluster support. Use it instead of implementing the same in this layer. Probably you can replace PooledClient by HashClient (with a few adjustments of arguments).\n\nhttps://pymemcache.readthedocs.io/en/latest/apidoc/pymemcache.client.hash.html#module-pymemcache.client.hash",
      "range": {
        "startLine": 283,
        "startChar": 8,
        "endLine": 284,
        "endChar": 1
      },
      "revId": "ba3a7531467418387b26f6bc0794b59728b02172",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "0215b53b_b1b589e1",
        "filename": "tooz/drivers/memcached.py",
        "patchSetId": 6
      },
      "lineNbr": 284,
      "author": {
        "id": 36759
      },
      "writtenOn": "2024-02-06T02:23:41Z",
      "side": 1,
      "message": "The implementation of pymemcache will retry for several times, if retry still fails, the client will mark the server as dead, kick the server from the server list, and route the request to other servers, this may cause some problems. For example, if a process acquired a lock, and then the server where the lock is located goes down, HashClient might route this request to another server, and then the process might acquire the lock, even though the lock on the original server had already been acquired by another process.",
      "parentUuid": "4a238b22_dee8f914",
      "range": {
        "startLine": 283,
        "startChar": 8,
        "endLine": 284,
        "endChar": 1
      },
      "revId": "ba3a7531467418387b26f6bc0794b59728b02172",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "70b630ff_4a630a7f",
        "filename": "tooz/drivers/memcached.py",
        "patchSetId": 6
      },
      "lineNbr": 284,
      "author": {
        "id": 9816
      },
      "writtenOn": "2024-02-06T03:25:55Z",
      "side": 1,
      "message": "If you do not prefer that kick out behavior then what\u0027s the point of supporting cluster ? Without that mechanism if you get any of your cluster nodes tooz may not function. It may have performance improvement but makes the cluster fragile.",
      "parentUuid": "0215b53b_b1b589e1",
      "range": {
        "startLine": 283,
        "startChar": 8,
        "endLine": 284,
        "endChar": 1
      },
      "revId": "ba3a7531467418387b26f6bc0794b59728b02172",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}