381 Commits

Author SHA1 Message Date
gujin
d4fd512305 tox: Keeping going with docs
Change-Id: Ieb99efd35108f4cb53e4f3f29da2415ba4152a9c
2019-11-03 02:48:48 +08:00
Zuul
a2c781508c Merge "Use module command to run podman" 2019-11-02 12:17:25 +00:00
Zuul
a000d22b31 Merge "Convert all of the fedora28 container usage to centos8" 2019-11-01 23:27:15 +00:00
Sagi Shnaidman
db6723e62d Use module command to run podman
with support of additional parameters for run_command of ansible.
Add expand_user_and_var=False to not expand users and vars
Change-Id: I07a8e5ed7d58c6e3e90c27f6cbf706489c6d558e
2019-11-01 22:46:03 +02:00
Zuul
77ac7f4fc7 Merge "tripleo-container-manage: add check tasks to the molecule playbook" 2019-11-01 19:26:25 +00:00
Emilien Macchi
c20ab42015 tripleo-container-manage: add check tasks to the molecule playbook
Verify that the "fedora" container exists and has the right infos.

Change-Id: If78a254564cff502b49769b0b401d2efdac8cb23
2019-11-01 16:30:41 +01:00
Emilien Macchi
5f138b57e3 paunch: use utils.load_config()
Use the new function that supports all use cases when loading
configurations. It supports old and new formats, files and directories.

Depends-On: I917679da22fa09614e73053654df6ce181cf98fe
Change-Id: Ic10d0c28c1a98708c30a1554489b589dd8f255cd
2019-11-01 11:29:09 +00:00
Zuul
a023564172 Merge "Add the skeleton role as an irrelevant file for scenarios" 2019-10-31 20:46:36 +00:00
Zuul
27494884ac Merge "Adding setup_rear and setup_nfs task" 2019-10-31 20:18:34 +00:00
Zuul
0c4ff0af1e Merge "Remove old Heat hosts entries in tripleo-hosts-entries" 2019-10-31 19:49:26 +00:00
Kevin Carter
db3692bd5e
Convert all of the fedora28 container usage to centos8
This change moves all of the fedora28 container images to centos8 to ensure
we're maximizing coverage in all of our roles with OS images that represent
real deployments. While fedora28 was useful to exercise RHEL8 code path's
while there was no RHEL/CentOS8 container image, we can now use the upstream
CentOS8 image ensuring we're getting a true, representitive, environment.

> In the process of testsing it was noticed that the test_deps role was
  triggering scenario jobs. This role is only used for test purposes and
  should not test scenarios deployments.

Molecule requirements have been updated to ensure we're testing with package
versions that reflect the realities of production deployments.

Hacks that were added to enable fedora28 testing have been removed.

The ptp role now only will test the ntp stop scenario on centos7. This is
done because there is no NTP package/service in centos8.

Change-Id: I0e960f9ee230c82edb2ad9d40557aa6d0237dfc0
Signed-off-by: Kevin Carter <kecarter@redhat.com>
2019-10-31 11:20:26 -05:00
Zuul
de0d5bca20 Merge "Add conditions to ceph roles for dependencies" 2019-10-31 12:42:59 +00:00
Kevin Carter
bd546f3de5
Add the skeleton role as an irrelevant file for scenarios
The skeleton role does not need to trigger tests with scenarios. It has no
production value and is only used for development purposes.

Change-Id: I0dc1be006d19a4eace3d6d2ad3a2d8f53263d6ef
Signed-off-by: Kevin Carter <kecarter@redhat.com>
2019-10-30 18:27:01 -05:00
James Slagle
0c0ea09be7
Remove old Heat hosts entries in tripleo-hosts-entries
For upgrades, this role now takes care of removing the old Heat entries
if they are present in /etc/hosts. The test prepare process has been
updated to create a temp file that would replicate what we'd expect
in a live system.

Change-Id: Ifc4d9553b74e6e6a9794902b418f54c0cfc7a39d
2019-10-30 16:59:17 -05:00
Zuul
f707588188 Merge "zuul/container-manage: trigger molecule jobs on more files" 2019-10-30 19:03:01 +00:00
Zuul
87e287f909 Merge "Adds new molecule testing for tripleo-container-manage" 2019-10-30 16:38:56 +00:00
Emilien Macchi
2e3a33f5d2 zuul/container-manage: trigger molecule jobs on more files
These files are used by the role; any change in them can break the role
so we need to run the molecule job against them.

Change-Id: I29b9ee64616f4410a6101beba18bd70fad7fdd5f
2019-10-30 17:24:18 +01:00
Cédric Jeanneret
414f47cc32 Adds new molecule testing for tripleo-container-manage
This test ensure the "create" part is working fine with an easy and
simple container. The container-create and default scenario have been
consoldated so its running one complete test for now.

Change-Id: I9139c7b63c15739a1a95d913acb1128af299ce97
Co-Authored-By: Emilien Macchi <emilien@redhat.com>
Signed-off-by: Kevin Carter <kecarter@redhat.com>
2019-10-30 13:00:48 +02:00
Telles Nobrega
b0fb6e2072 Adding setup_rear and setup_nfs task
Adding the tasks to install and configure ReaR and
install and configure NFS..

Change-Id: I960e45f2162f8e1257f952a14e7f876468aa8fca
2019-10-30 07:58:19 -03:00
Zuul
762e832713 Merge "tripleo-container-manage: few improvements" 2019-10-30 04:18:27 +00:00
Zuul
094d67a499 Merge "Run scenario004 for changes to tripleo-ceph-* roles" 2019-10-30 01:42:28 +00:00
Zuul
a62cab164a Merge "Ensure plugin path is correct" 2019-10-30 00:05:08 +00:00
Zuul
4524b510fb Merge "Add support for --limit option into ceph-ansible call" 2019-10-30 00:05:07 +00:00
Emilien Macchi
9c69840640 tripleo-container-manage: few improvements
- Add and use variables to make the role more flexible:
  tripleo_container_manage_config,
  tripleo_container_manage_config_id
  tripleo_container_manage_debug
  tripleo_container_manage_config_pattern (and rename hashed_files var)

  With these vars, the role can pretty much be used outside of TripleO.

- Show logs of config data generation if debug is enabled

- Do not run the "podman exec" tasks in check mode

- Remove the dependency on the "step" variable

Change-Id: I28ee31b723f27c392f880676aaae9368906cf45f
2019-10-29 17:40:45 -05:00
Zuul
52e43017bf Merge "Revert "Workaround for ansible-lint installation failure"" 2019-10-29 22:29:41 +00:00
Kevin Carter
448c591086 Add conditions to ceph roles for dependencies
This change adds several conditions to the ceph roles so that when
they're included as a dependency they're only run when required.
This will ensure we're optimizing the runtime while also making the
log output a little quieter.

Change-Id: If5a2a60ce6769164f16e92bf1d4220216507f45e
Signed-off-by: Kevin Carter <kecarter@redhat.com>
2019-10-29 21:40:09 +00:00
Giulio Fidente
f613dbdbb7 Run scenario004 for changes to tripleo-ceph-* roles
Also enables scenario001 for changes to tripleo-ceph-* roles

Change-Id: Icd0512cb2a92faef1109144e48d93901cf2e8371
2019-10-29 21:40:04 +00:00
Kevin Carter
3186edf000
Ensure plugin path is correct
Updates the molecule plugin path for the ovs-dpdk and package
roles. This is done to ensure the role works in all molecule
based test environments when the test env rc file is sourced.

Change-Id: I4ccb230268b687fc546205af5c73c4a6fc110eae
Signed-off-by: Kevin Carter <kecarter@redhat.com>
2019-10-29 11:49:55 -05:00
Jesse Pretorius (odyssey4me)
28e105c056 Revert "Workaround for ansible-lint installation failure"
This reverts the disabling of the ansible-lint test from
commit cffd4fc9d41b15c31610dee4abd8786916f5933b and updates
ansible-lint to the fixed version.

Included are fixes for ansible-lint test failures which
got merged as part of I2f88caa8e1c230dfe846a8a0dd9f939b98992cd5
while the lint test was disabled.

Change-Id: I37100f5e1764a5cd2cb8df82ae963e673ca0a8da
2019-10-29 13:25:49 +00:00
Zuul
0a82a97f89 Merge "Move the filters plugin to the core plugins location" 2019-10-29 11:19:00 +00:00
Zuul
081d99dc53 Merge "Revert "Remove roles symlink"" 2019-10-29 00:26:09 +00:00
Zuul
d804d8c68c Merge "Add tripleo-hosts-entries role" 2019-10-29 00:26:08 +00:00
Zuul
fd81ef9668 Merge "Drop unnecessary tripleo_ prefix from skeleton role" 2019-10-29 00:07:16 +00:00
Zuul
629ef26a43 Merge "Fix typo in skeleton role" 2019-10-29 00:07:15 +00:00
Kevin Carter
e2719131db
Move the filters plugin to the core plugins location
This change is a workaround for a zuul issue which moves the
nested ansible role plugin to the core plugins directory so
that it is not creating a gate conflict.

Change-Id: I9f959803381063502b4d15980b14c3416ffa153f
Signed-off-by: Kevin Carter <kecarter@redhat.com>
2019-10-28 16:55:03 -05:00
Alex Schultz
9aacc369fb Revert "Remove roles symlink"
This reverts commit 196a5043b9676e7b7d5a5b0c15a338b4d61aa639.

This breaks RDO jobs because they assume the roles dir.

aca1107d42. 

We'll need to go with https://review.opendev.org/#/c/691716/ for now.

Change-Id: I84e1fef1d2206b068f74134f49cd4d7591d8f826
2019-10-28 21:43:35 +00:00
Alex Schultz
196a5043b9 Remove roles symlink
Zuul currently breaks because it finds a roles location in the repo and
tries to load things from it. See also
https://review.opendev.org/#/c/691716/

Change-Id: Ie4787a0e73dd4494d6f5e1172054748f16c30b78
2019-10-28 10:51:39 -06:00
Giulio Fidente
bd6975a273 Add support for --limit option into ceph-ansible call
This will be useful when executing playbooks which can't run against
all nodes. For example the newly introduced docker-to-podman playbook
meant to migrate systemd units from docker to podman for compatibility
with newer CentOS versions.

Change-Id: I4538d64ed49b4a6e4670d1e1d050fc5443e2edb0
2019-10-28 13:17:26 +00:00
Emilien Macchi
609d7895a1 tripleo-container-manage: set some defaults
Set defaults that are needed to use the role outside of THT more easily.

Change-Id: Id67cf06c85a2a6b50e6494b1a66f534ccb06c4a7
2019-10-27 22:24:29 +01:00
Zuul
115e95bcae Merge "Introduce tripleo-container-manage role" 2019-10-25 18:00:45 +00:00
James Slagle
207e350ca6 Add tripleo-hosts-entries role
Add a new role to manage /etc/hosts entries. Instead of these entries
being calculated by Heat, a jinja2 expression is used to construct the
individual hosts entries for each overcloud nodes.

Some data still comes out of Heat, such as those for the undercloud,
vips, and extra hosts entries used for multi-stack. As such, variables
are used for these entries so that the role can add them to /etc/hosts.

Change-Id: I1e12962e2f2fa6c1a2b429a3e02424fd42b0a08d
2019-10-25 11:37:56 -04:00
Zuul
a77f030732 Merge "Fix invalid variable issue with StorageNFS" 2019-10-25 04:23:53 +00:00
James Slagle
2424c6d4a9 Drop unnecessary tripleo_ prefix from skeleton role
This patch updates the skeleton role to not add the unnecessary
"tripleo_" prefix when a role name already starts with "tripleo-".

Also updates the generated roles that were affected by this change.

Change-Id: Ib1f604a098cc5d7e8c1a5aa5fe2c8e339e263c91
2019-10-24 09:01:13 -04:00
James Slagle
bc6ccf2240 Fix typo in skeleton role
Fixes a typo in the skeleton role and the generated roles that had been
affected.

Note that the tripleo-packages and tripleo-ovs-dpdk roles are excluded
from being updated because those CI jobs are presently failing.

Change-Id: I0d66af8c5395a0ee4910f8475e1f70ccb7bfa52c
2019-10-24 09:01:13 -04:00
Emilien Macchi
a191a2d600 Introduce tripleo-container-manage role
This is a first ieration of the role, but there is still a long TODO,
that will come later in separated patches:
- Add molecule testing
- In podman.yaml, add cpuset_cpus with parity of what is in paunch
- Remove containers that are:
  - managed by tripleo-ansible (using the container_label flag)
  - not in the container-startup-config
- Print stdout when containers start as it was done with paunch

Story: 2006732
Task: 37165

Co-Authored-By: Kevin Carter <kecarter@redhat.com>
Co-Authored-By: Alex Schultz <aschultz@redhat.com>

Change-Id: I2f88caa8e1c230dfe846a8a0dd9f939b98992cd5
2019-10-24 12:14:10 +02:00
Zuul
231aa5316d Merge "Tighten up how we add and remove kernel modules" 2019-10-23 20:00:23 +00:00
Kevin Carter
0bcb4b906e Tighten up how we add and remove kernel modules
This change adjusts our two roles that configure kernel modules.
These two roles serve slightly different purposes so they both
must exist at this time. The change being made will ensure that
the system module-load service is in reloaded anytime modules
change, and that the `/etc/modules-load.d` directory exists
before assuming we can write new configuration files there.

> Molecule configuration for the tripleo-module-load role has
  been updated to ensure the role is functionally testing the
  code paths with real system values.

Closes-Bug: #1847282
Change-Id: Id20d7415e8430c66f3afc8f86e0e813a54ee3ca2
Signed-off-by: Kevin Carter <kecarter@redhat.com>
2019-10-23 14:14:38 +00:00
Zuul
0e7d4eb7cc Merge "Fix the filter plugin location for triple-ovs-dpdk role" 2019-10-23 01:18:30 +00:00
Goutham Pacha Ravi
e3625095ea Fix invalid variable issue with StorageNFS
The `ganesha_vip` comes from a network
called StorageNFS; but its lookup in the
`net_vip_map` dictionary was incorrect.

Change-Id: I5a8b49cce65963d35b610e138808030ed84de2de
Closes-Bug: #1849393
2019-10-22 17:33:51 -07:00
Emilien Macchi
840e3c0e65 paunch: only read container config JSON which starts by "hashed-"
The container-puppet.py generates the hashed-*.json file, which is a copy of
the *step_n.json with a hash of the generated external config added.
(This acts as a salt to enable restarting the container if config
changes)

We want to filter files starting by hashed- otherwise paunch will start
the other containers which will clash with the hashed ones.
Also make sure the container name doesn't have the "hashed-" prefix.

Change-Id: If0f1c6c308cd58f7baa9a8449fbf685ff10f0e0a
2019-10-22 12:35:48 +02:00