openstack/tripleo-common
Code Issues Proposed changes

Ensure lanplus is unset when using redfish

Browse Source 
This avoids the additional burden of having to explicitly add
'--ipmi-no-lanplus' to the generate fencing command.

Change-Id: I1eab370213ce8d1f71f70016b481128254cec046
(manually cherry picked from commit b440733f43)
This commit is contained in:
Luca Miccini
2020-06-23 13:55:16 +02:00
committed by Alex Schultz
parent 6488f98c03
commit 34283f29c1
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tripleo_common/actions/parameters.py
View File

@@ -445,12 +445,13 @@ class GenerateFencingParametersAction(base.TripleOAction):
if driver_proto in {'ipmi', 'ipmitool', 'drac', 'idrac', 'ilo',
'redfish'}:
# IPMI fencing driver
if driver_proto == "redfish":
node_data["agent"] = "fence_redfish"
params["systems_uri"] = node["pm_system_id"]
else:
node_data["agent"] = "fence_ipmilan"
if self.ipmi_lanplus:
params["lanplus"] = self.ipmi_lanplus
params["ipaddr"] = node["pm_addr"]
params["passwd"] = node["pm_password"]
params["login"] = node["pm_user"]
@@ -464,8 +465,6 @@ class GenerateFencingParametersAction(base.TripleOAction):
params["ssl_insecure"] = "true"
else:
params["ssl_insecure"] = "false"
if self.ipmi_lanplus:
params["lanplus"] = self.ipmi_lanplus
if self.delay:
params["delay"] = self.delay
if self.ipmi_cipher:

1
tripleo_common/tests/actions/test_parameters.py
View File

@@ -1252,7 +1252,6 @@ class GenerateFencingParametersActionTestCase(base.TestCase):
"delay": 28,
"ipaddr": "172.16.0.1:8000",
"ipport": "8000",
"lanplus": True,
"privlvl": 5,
"login": "root",
"passwd": "calvin",