openstack
/
tripleo-heat-templates
Code Issues Proposed changes

[ipaclient] Fix type of MakeHomeDir heat param 

https://review.opendev.org/#/c/650899 added this new
Heat Parameter but set type to 'bool', the correct type
is 'boolean', this patch fixes it.

Also change the comparison in shell script to handle
both True/true by converting the variable to lower case.

Related-Bug: #1823727
Change-Id: I52ba523ecbfd8282858e3102b29189d8ce287a26
This commit is contained in:
yatinkarel 2019-05-10 10:36:19 +05:30
parent 33c98887c0
commit 2471642f6f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
extraconfig/services/ipaclient.yaml
View File

@ -37,7 +37,7 @@ parameters:
description: The python interpreter to use for python and ansible actions description: The python interpreter to use for python and ansible actions
default: /usr/bin/python default: /usr/bin/python
MakeHomeDir: MakeHomeDir:
type: bool type: boolean
description: Configure PAM to create a users home directory if it does not exist. description: Configure PAM to create a users home directory if it does not exist.
default: False default: False
@ -142,7 +142,7 @@ outputs:
if [ -n "$realm" ]; then if [ -n "$realm" ]; then
OPTS="$OPTS --realm=$realm" OPTS="$OPTS --realm=$realm"
fi fi
if [ "$makehomedir" = "True" ]; then if [ "${makehomedir,,}" = "true" ]; then
OPTS="$OPTS --mkhomedir" OPTS="$OPTS --mkhomedir"
fi fi