openstack/tripleo-heat-templates
Code Issues Proposed changes

Fix the failure condition for HAproxy chgrp script

Browse Source 
Follows-up I4b40d73ab329dc219ee7a387201b0747a6233ed4

Do not fail if haproxy container UUID changes.

Reasoning behind: at the time the chgrp&HUP block is executed, the new
cert has already been deployed on the host, with the correct owner
already set. So if the container_id changes at this time, it will pick
up the new cert automatically. That means that by ignoring errors
caused by mismatching UUID we'd skip an unnecessary consequent restart
of the newly spawned container, ending up with the same result. So the
safest path here would provide a sort of a cascading failure for the
crasher->restarted->reloaded once again containers.

Related rhbz#1973674
Closes-bug: #1940729
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>

Change-Id: Ib0dd1516592428413452b8a260182f36e42d5b3d
This commit is contained in:
Bogdan Dobrelya 2021-09-01 18:01:39 +02:00
parent 835c6a04bc
commit a235b70b2e
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
deployment/haproxy/haproxy-public-tls-inject.yaml
View File

@ -184,6 +184,7 @@ outputs:
{{ container_cli }} kill --signal=HUP {{ item }}
register: container_kill_result
failed_when:
- container_kill_result.rc != 0
- ("no such container" not in container_kill_result.stderr)
- ("container state improper" not in container_kill_result.stderr)
with_items: "{{ container_id.stdout.split('\n') }}"