Stop octavia servics in unupgraded controllers

This change makes octavia services on unupgrade controller nodes get
stopped, because all services in the unupgrade controllers should be
stopped before we start the upgraded controller[1].

[1] 8529ce60da

Change-Id: I51855841c269ec593933288af4135f5d06a139fe

deployment/octavia/octavia-api-container-puppet.yaml

@@ -456,3 +456,18 @@ outputs:
             - step|int == 2
             - internal_tls_enabled|bool
           block: *remove_octavia_tls_proxy_tasks
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop octavia api container
+              import_role:
+                name: tripleo_container_stop
+              vars:
+                tripleo_containers_to_stop:
+                  - octavia_api
+                tripleo_delegate_to: "{{ groups['octavia_api'] | default([]) }}"

deployment/octavia/octavia-health-manager-container-puppet.yaml

@@ -206,3 +206,18 @@ outputs:
           with_items:
             - { 'path': /var/log/containers/octavia, 'setype': container_file_t, 'mode': '0750' }
             - { 'path': /var/log/containers/octavia-amphorae, 'setype': container_file_t, 'mode': '0750' }
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop octavia health manager container
+              import_role:
+                name: tripleo_container_stop
+              vars:
+                tripleo_containers_to_stop:
+                  - octavia_health_manager
+                tripleo_delegate_to: "{{ groups['octavia_health_manager'] | default([]) }}"

deployment/octavia/octavia-housekeeping-container-puppet.yaml

@@ -157,3 +157,18 @@ outputs:
           with_items:
             - { 'path': /var/log/containers/octavia, 'setype': container_file_t, 'mode': '0750' }
       upgrade_tasks: []
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop octavia housekeeping container
+              import_role:
+                name: tripleo_container_stop
+              vars:
+                tripleo_containers_to_stop:
+                  - octavia_housekeeping
+                tripleo_delegate_to: "{{ groups['octavia_housekeeping'] | default([]) }}"

deployment/octavia/octavia-worker-container-puppet.yaml

@@ -168,3 +168,18 @@ outputs:
             persistent: yes
             state: yes
       upgrade_tasks: []
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop octavia api container
+              import_role:
+                name: tripleo_container_stop
+              vars:
+                tripleo_containers_to_stop:
+                  - octavia_worker
+                tripleo_delegate_to: "{{ groups['octavia_worker'] | default([]) }}"