This was mainly there as an legacy interface which was
for internal use. Now that we pull the passwords from
the existing environment and don't use it, we can drop
this.
Reduces a number of heat resources.
Change-Id: If83d0f3d72a229d737a45b2fd37507dc11a04649
Debug always has one of true/false and is always set. We should check
whether HorizonDebug is set instead of whether Debug is set.
Also, this change fixes the current logic to make sure that
HorizonDebug: false is honored even when Debug: true is set.
Closes-Bug: #1908362
Change-Id: I514b5a3d4133d3561376ea06a803d019acaa0f0b
Because the dependent patch[1] does not present in stable/victoria
we should not merge this patch until stable/victoria release is created
for TripleO projects.
This revert will be reverted once stable/victoria branch is created.
This reverts commit d3b099fac949bed6e5da0660b13509cf391ca571.
Resolved conflict caused by the subsequemtn commit[2]
[1] https://review.opendev.org/#/c/758041/
[2] 132c0b1e792084664920fc8ac6c984cb4d1b823d
Conflicts:
deployment/horizon/horizon-container-puppet.yaml
Related-Bug: #1901626
Change-Id: I1cc635715084789602fc40084ba5df4d5790199c
The recent change in puppet-horizon[1] made the ssl_verify_client
parameter mandatory when ssl_ca is set. This patch makes sure that
the ssl_verify_client parameter is set properly.
In addition, internal tls cert is not valid when internal tls is not
enabled. This patch also addresses that point, and make ssl_ca is set
only when needed.
[1] https://review.opendev.org/#/c/758041/6
Closes-Bug: #1900947
Change-Id: I286f69b8d3775d7538685e799f092ce47b5d75a7
A recent change to puppet-horizon refactored the SSL parameter names
[0]. This change updates THT to use the right name for the CA value.
[0] https://review.opendev.org/#/c/758041/6
Change-Id: I2957cf529c3ba00269fded75a26dcd6d806fb18e
Sahara support was deprecated during previous Ussuri cycle[1], so we
can remove it completely now.
[1] f1d9b15c85fd1ed2250d40cea8184a18f458234f
Change-Id: Id047221cb912c09984cc3bf864196a26fd36736f
This patch adds HorizonLoggingSource parameter to enable fluentd to tail logs
from Horizon.
To keep consistency with other services the default value is set as single log located
in appropriate log directory, but we also need to enable customer to pass multiple
horizon log files also used by httpd.
Change-Id: I0161e6d9c76424b301e48b73f1d7b4b071af0676
Add HorizonSessionTimeout parameter for configuring the session timeout
of horizon in seconds.
Closes-Bug: #1897197
Change-Id: I1bfd645ed9e1823a626d6972ab00893ca49bba83
Previously, if HorzionDebug of Debug was true, horizon::django_debug
was set to True. However, those parameters didn't change the logger
level of horizon components. By this change, when HorizonDebug or
Debug is True, horizon::log_level is set to 'DEBUG'.
Change-Id: I0a140682c552ba8a4e943124330852259e66142d
For containers which run httpd, make sure conf.modules.d is also synced
into the container; so apache doesn't fail with:
AH00534: httpd: Configuration error: More than one MPM loaded.
This is now required since:
6425cc46a8
Change-Id: Ib315d10dbdbbad1628f536a74cd1fca371f018f5
Closes-Bug: #1884115
There is a help button in horizon dashboard that has various
use cases:
- by default it should point to upstream documentation;
- OpenStack vendor could adjust this URL, so it will point
to his documentation;
- every cloud operator could adjust this URL, so users will
be re-directed to some custom portal.
This patch adds an option to configure custom URL for Help
button using HorizonHelpURL parameter.
Change-Id: Ic95e55a007ea6db9336e81574c7a49185590eaee
Closes-Bug: #1879522
Related: rhbz#1835820
Detect the IP version used instead of relying on the
user specifying the IP version for services.
The IP version is stored in a net_ip_version_map which
is passed to all services in ServiceData.
Deprecates the following parameters:
CephIPv6, CorosyncIPv6, RabbitIPv6, MemcachedIPv6,
MysqlIPv6, RedisIPv6 and NeutronOverlayIPVersion.
Change-Id: Iebfd8ef686381be2f45d0d4c45dfd6bf654d1ac6
Almost every single tripleo service creates a persistent directory. To
simplify the creation, a with_items structure was being used. In which
many times, the mode option was being set. However, that mode option
was not taken into account at the time of creating the file. As a
consequence, the directory was being created with its father directory
rights, instead of the ones being passed in the template.
Change-Id: I215db2bb79029c19ab8c62a7ae8d93cec50fb8dc
Closes-Bug: #1871231
Current puppet modules uses only absolute name to include classes,
so replace relative name by absolute name in template files so that
template description can be consistent with puppet implementation.
Change-Id: I7a704d113289d61ed05f7a31d65caf2908a7994a
Since Stein release it is possible to set
OPENSTACK_KEYSTONE_DOMAIN_CHOICES using puppet-horizon
(change-id: I67c4c8923ef4d6e4c3420e0a2b0d38ee3c6e2819 ).
This patch adds THT parameter to set
horizon::keystone_domain_choices
Fixes: rhbz#1732672
Change-Id: Iebd7ab7c111a6c3a15ee90f3acf47138138568bc
Now we have heat-dashboard installed, so remove the outdated comment
we had before adding heat-dashboard.
Change-Id: I42586af1493b8dc8601bfe974363505c075781c0
While they are, at SELinux level, exactly the same (one is an alias to
the other), the "container_file_t" name is easier to understand (and
shorter to write).
A second pass in a couple of days or weeks will be needed in order to
change files that were merged after this first pass.
Change-Id: Ib4b3e65dbaeb5894403301251866b9817240a9d5
To avoid empty volumes like:
{
(...)
"volumes": [
"/etc/puppet:/etc/puppet:ro",
(...)
"",
""
],
}
Replace '' by [], so heat won't create an item in the list.
It helps to have idempotent containers, since podman_container module
will compare the list of volumes that is given in parameters (containing
the empty entries) vs the list of volumes actually in podman inspect.
Replacing to [] clears out empty volumes and makes these containers
idempotent when podman_container module is used to deploy containers.
Change-Id: I228b01009e7d9980bee5480778dbc88b9e226297
Ansible has decided that roles with hypens in them are no longer supported
by not including support for them in collections. This change renames all
the roles we use to the new role name.
Depends-On: Ie899714aca49781ccd240bb259901d76f177d2ae
Change-Id: I4d41b2678a0f340792dd5c601342541ade771c26
Signed-off-by: Kevin Carter <kecarter@redhat.com>
Without quotes, it seems like Ansible "from_yaml" filter will convert
yes to True and no to False; which is problematic in the case of Kolla
image for Horizon where the extend_start script checks for yes/no and
not the actual booleans.
Putting them between quotes seems to solve the issue.
Change-Id: Ie08726c0916c55c3d4c315b63ee341196cc2e70e
Closes-Bug: #1859491
When podman parses such volume map it removes the slash
automatically and shows in inspection volumes w/o slash.
When comparing configurations it turns to be a difference and
it breaks idempotency of containers, causing them to be recreated.
Change-Id: Ifdebecc8c7975b6f5cfefb14b0133be247b7abf0
This change converts our filewall deployment practice to use
the tripleo-ansible firewall role. This change creates a new
"firewall_rules" object which is queried using YAQL from the
"FirewallRules" resource.
A new parameter has been added allowing users to input
additional firewall rules as needed. The new parameter is
`ExtraFirewallRules` and will be merged on top of the YAQL
interface.
Depends-On: Ie5d0f51d7efccd112847d3f1edf5fd9cdb1edeed
Change-Id: I1be209a04f599d1d018e730c92f1fc8dd9bf884b
Signed-off-by: Kevin Carter <kecarter@redhat.com>
When upgrading from Rocky to Stein we moved also from using the docker
container engine into Podman. To ensure that every single docker container
was removed after the upgrade a post_upgrade task was added which made
use of the tripleo-docker-rm role that removed the container. In this cycle,
from Stein to Train both the Undercloud and Overcloud work with Podman, so
there is no need to remove any docker container anymore.
This patch removes all the tripleo-docker-rm post-upgrade task and in those
services which only included a single task, the post-upgrade-tasks section
is also erased.
Change-Id: I5c9ab55ec6ff332056a426a76e150ea3c9063c6e
We switched to containers a long time ago. This patch drops the
management of a /var/log/<service> directory and the creation of a
readme indicating that we've moved to containers which makes the logging
available under /var/log/containers/<service>
Change-Id: Ia4e991d5d937031ac3312f639b726a944743dd1e
We should ensure that the service folders are 0750. We're setting
/var/log/containers but we should also ensure the service folders also
have the correct permissions.
Change-Id: I28e8017edc7e30a60288adf846da722fd6ab310e
Moving all the container environments from lists to dicts, so they can
be consumed later by the podman_container ansible module which uses
dict.
Using a dict is also easier to parse, since it doesn't involve "=" for
each item in the environment to export.
Change-Id: I894f339cdf03bc2a93c588f826f738b0b851a3ad
Depends-On: I98c75e03d78885173d829fa850f35c52c625e6bb
Previously we use /tmp inside horizon container to store temporal files
for image upload via Horizon, but this makes the image size grow for
each upload operation.
This patch makes sure that we use host directory to store temporal
file, so that it is not written inside container.
Change-Id: Ic32e7a2db83bb5a0fb3c69708be9be96435dd030
Closes-Bug: 1840607
Before we start services on upgraded bootstrap
controller (usually controller-0), we need to
stop services on unupgraded controllers
(usually controller-1 and controller-2).
Also we need to move the mysql data transfer
to the step 2 as we need to first stop the
services.
Depends-On: I4fcc0858cac8f59d797d62f6de18c02e4b1819dc
Change-Id: Ib4af5b4a92b3b516b8e2fc1ae12c8d5abe40327f
Allow to configure Apache MPM module for the containerized API/WSGI'ish
services running Apache as a backend. Change the default from 'prefork'
to 'event', which is a low level change and should provide no sensible
upgrade impact. This alleviates the related heartbeats threading issue
arising with the monkey-patched eventlet.
Merge the missing ApacheServiceBase config settings for Octavia API,
Horizon and Ironix PXE. This is needed to apply the base Apache
service hiera settings, including MPM module switches, for those
as well.
Related-bug: #1829062
Change-Id: Ia65af7a9d6ae106a61ec52912bebba72830d5f28
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
The changes listed below provide a single unit of work required to
configure Apache backend for WSGI-based OpenStack API services
w/o conflicts causing containers startup failures.
W/o this change /etc/httpd/conf.modules.d/00-mpm.conf shipped with RPM
or other conflicting httpd modules might remain in the containers
and cause startup failures. While puppet removes such conflicts from
the configuration, f.e. when switching MPM 'prefork' to 'event', and we
expect it never gets into container configs.
Make kolla extended start properly enforcing the wanted state of
/etc/httpd, including conf.d and conf.modules.d, and also any of the
removed by puppet files, like conflicting Apache MPM modules.
Add container-puppet tasks to ensure apache MPM configs generated
before the main config steps that require Apache started in the
service container.
Additionally, ensure consistent mirroring across config-data
paths for the container-puppet tool. Purge obsoleted/irrelevant files
in the destingation (puppet-generated) before rsyncing new contents
into it.
Closes-Bug: #1835414
Change-Id: I3e5b4372a01b29bf13179d8a16acc36da9c5caab
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
The tripleo-docker-rm role has been replaced by tripleo-container-rm [0].
This role will identify the docker engine via the container_cli variable
and perform a deletion of that container. However, these tasks inside the
post_upgrade_tasks section were thought to remove the old docker containers
after upgrading from rocky to stein, in which podman starts to be the
container engine by default.
For that reason, we need to ensure that the container engine in which the
containers are removed is docker, as otherwise we will be removing the
podman container and the deployment steps will fail.
Closes-Bug: #1836531
[0] - 2135446a35
Depends-On: https://review.opendev.org/#/c/671698/
Change-Id: Ib139a1d77f71fc32a49c9878d1b4a6d07564e9dc
The Shared File Systems service (manila) provides
a dashboard plugin that needs to be enabled by
tripleo. It appears that it was disabled inadvertently
while triaging a bug with the dashboard and sqlite.
See: Launchpad bug #1766184
and associated commit: https://review.opendev.org/#/c/613186/
Change-Id: If4bc4ed0e9fa31e11a5a701dc57ffdf67aade861
Closes-Bug: #1832302
This converts all Docker*Image parameter varients into
Container*Image varients.
The commit was autogenerated with the following shell commands:
for file in $(grep -lr Docker.*Image --include \*.yaml --exclude-dir releasenotes); do
sed -e "s|Docker\([^ ]*Image\)|Container\1|g" -i $file
done
Change-Id: Iab06efa5616975b99aa5772a65b415629f8d7882
Depends-On: I7d62a3424ccb7b01dc101329018ebda896ea8ff3
Depends-On: Ib1dc0c08ce7971a03639acc42b1e738d93a52f98
The project has been retired and there will be no Train release [1].
This patch removes Neutron LBaaS support in tripleo-heat-templates.
[1] https://review.opendev.org/#/c/658494/
Closes-Bug: #1831618
Change-Id: If13bbcdea82045d816485412f252c9b52bcf45a7
This breaks the rules for the haproxy stats access because it
shadows them. Let's remove these rules and move the iptables
rules for haproxy in puppet-tripleo where they should have
been in the first place, like for all other services.
Depends-On: I1325171ef60d7a7e3b57373082fcdb5487be939b
Change-Id: I2f177c930567b3a45f0d95cec4140f478f14a074
Closes-Bug: #1829338