Raise exception if no validation is found
In addition, I have to fix pep8 issue, due to new version
Change-Id: I04728bfdb6473c47c248a4a56bb8df647c51f5ef
(cherry picked from commit ade5d57a3e
)
This commit is contained in:
parent
497c367dd1
commit
c744ff2198
|
@ -81,6 +81,16 @@ class TestValidationActions(TestCase):
|
||||||
validations_dir='/tmp/foo')
|
validations_dir='/tmp/foo')
|
||||||
self.assertEqual(run_return, expected_run_return)
|
self.assertEqual(run_return, expected_run_return)
|
||||||
|
|
||||||
|
@mock.patch('validations_libs.utils.get_validations_playbook')
|
||||||
|
def test_validation_run_wrong_validation_name(self, mock_validation_play):
|
||||||
|
mock_validation_play.return_value = []
|
||||||
|
|
||||||
|
run = ValidationActions()
|
||||||
|
self.assertRaises(RuntimeError, run.run_validations,
|
||||||
|
validation_name='fake.yaml',
|
||||||
|
validations_dir='/tmp/foo'
|
||||||
|
)
|
||||||
|
|
||||||
@mock.patch('validations_libs.validation_logs.ValidationLogs.get_results')
|
@mock.patch('validations_libs.validation_logs.ValidationLogs.get_results')
|
||||||
@mock.patch('validations_libs.utils.parse_all_validations_on_disk')
|
@mock.patch('validations_libs.utils.parse_all_validations_on_disk')
|
||||||
@mock.patch('validations_libs.ansible.Ansible.run')
|
@mock.patch('validations_libs.ansible.Ansible.run')
|
||||||
|
|
|
@ -88,6 +88,10 @@ class ValidationActions(object):
|
||||||
playbooks = v_utils.get_validations_playbook(validations_dir,
|
playbooks = v_utils.get_validations_playbook(validations_dir,
|
||||||
validation_name,
|
validation_name,
|
||||||
group)
|
group)
|
||||||
|
if not playbooks:
|
||||||
|
msg = "Validation {} not found in {}.".format(validation_name,
|
||||||
|
validations_dir)
|
||||||
|
raise RuntimeError(msg)
|
||||||
else:
|
else:
|
||||||
raise RuntimeError("No validations found")
|
raise RuntimeError("No validations found")
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue