Remove 7 unused methods from NovaHelper that have no production
usage. These methods have been thoroughly verified against all 290
production files and are only used in unit tests or not used at all.
High-confidence removals:
- delete_instance(): Remnant from old snapshot-based migration
workflow replaced in commit 4179c352 with Nova native migration API
- get_availability_zone_list(): Added in 2016 for audit scope, never
used
- get_instance_by_name(): Added in 2019 refactor, never integrated
- get_instances_by_node(): Added in 2019 refactor, never integrated
- get_service(): Added in 2017 for graph model, never integrated
Security-related removals:
- swap_volume(): Usage removed in commit 4fca7d24 due to data loss
risks and security concerns with credential forging
- wait_for_instance_status(): Unused since 2015, redundant with
wait_for_instance_state()
All methods reverified against complete production file list.
Removing approximately 139 lines of code reduces maintenance burden
and eliminates code with known security issues.
Generated-By: cursor
Assisted-By: claude-code
Closes-Bug: #2126969
Change-Id: Ic4a40a78fbb7c1bb9f659d8e801f25713c66c461
Signed-off-by: Sean Mooney <work@seanmooney.info>
6bfbee1265