openstack/watcher
Code Issues Proposed changes
Files
f25853733515f1e3e56407263c1da2e0c4a356cb
watcher/releasenotes/notes
History
Sean Mooney 6bfbee1265 Remove dead NovaHelper methods 
Remove 7 unused methods from NovaHelper that have no production
usage. These methods have been thoroughly verified against all 290
production files and are only used in unit tests or not used at all.

High-confidence removals:
- delete_instance(): Remnant from old snapshot-based migration
  workflow replaced in commit 4179c352 with Nova native migration API
- get_availability_zone_list(): Added in 2016 for audit scope, never
  used
- get_instance_by_name(): Added in 2019 refactor, never integrated
- get_instances_by_node(): Added in 2019 refactor, never integrated
- get_service(): Added in 2017 for graph model, never integrated

Security-related removals:
- swap_volume(): Usage removed in commit 4fca7d24 due to data loss
  risks and security concerns with credential forging
- wait_for_instance_status(): Unused since 2015, redundant with
  wait_for_instance_state()

All methods reverified against complete production file list.
Removing approximately 139 lines of code reduces maintenance burden
and eliminates code with known security issues.

Generated-By: cursor
Assisted-By: claude-code
Closes-Bug: #2126969
Change-Id: Ic4a40a78fbb7c1bb9f659d8e801f25713c66c461
Signed-off-by: Sean Mooney <work@seanmooney.info>
2025-10-08 11:53:01 +01:00
..
.placeholder
Add reno for release notes management
2016-06-09 11:01:20 +02:00
2025.1-prelude-8be97eece4e1d1ff.yaml
Add epoxy prelude
2025-03-05 17:57:55 +00:00
2025.2-prelude-a9f4c7b2e8d15692.yaml
Add 2025.2 release notes prelude
2025-09-09 17:43:53 +01:00
action-plan-cancel-c54726378019e096.yaml
Cancel Action Plan
2017-06-07 05:36:18 +00:00
action-plan-versioned-notifications-api-e8ca4f5d37aa5b4b.yaml
Add release note for action plan notifications
2017-02-02 17:35:07 +01:00
action-versioned-notifications-api-ff94fc0f401292d0.yaml
Add release notes for Pike
2017-07-26 10:45:15 +03:00
add-baremetal-scoper-9ef23f5fb8f0be6a.yaml
Add audit scoper for baremetal data model
2018-11-26 12:21:06 +03:00
add-fail-options-to-nop-f44f506dc732f2a1.yaml
Add parameters to force failures in nop action
2025-08-19 11:05:11 +02:00
add-force-field-to-audit-4bcaeedfe27233ad.yaml
Audit API supports new force option
2019-05-27 02:08:33 +00:00
add-ha-support-b9042255e5b76e42.yaml
Add HA support
2018-07-26 12:54:11 +03:00
add-instance-metrics-to-prometheus-datasource-9fba8c174ff845e1.yaml
Add support for instance metrics to prometheus datasource
2025-01-23 13:23:04 +01:00
add-name-for-audit-0df1f39f00736f06.yaml
Add missing release notes
2018-02-09 11:45:05 +03:00
add-plugins-parameters-376eb6b0b8978b44.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
add-power-on-off-a77673d482568a8b.yaml
Add action for compute node power on/off
2017-06-13 15:07:33 +08:00
add-scoring-module-fa00d013ed2d614e.yaml
[pre-commit] fix typos and configure codespell
2024-11-07 19:50:21 +00:00
add-start-end-time-for-continuous-audit-52c45052cb06d153.yaml
add start and end time for continuous audit
2018-10-12 11:21:17 +03:00
add-upgrade-check-framework-5bb9693c8a78931c.yaml
Add framework for watcher-status upgrade check
2018-10-22 13:51:56 +05:30
add-wsgi-module-support-597f479e31979270.yaml
Add support for pyproject.toml and wsgi module paths
2025-05-01 00:19:59 +00:00
aetos-datasource-60e50a2338c64c08.yaml
Add Aetos datasource
2025-08-14 02:27:24 -04:00
api-call-retry-fef741ac684c58dd.yaml
[pre-commit] fix typos and configure codespell
2024-11-07 19:50:21 +00:00
api-microversioning-7999a3ee8073bf32.yaml
[pre-commit] fix typos and configure codespell
2024-11-07 19:50:21 +00:00
audit-scoper-for-storage-data-model-cdccc803542d22db.yaml
Audit scoper for storage CDM
2018-01-23 13:53:31 +05:30
audit-tag-vm-metadata-47a3e4468748853c.yaml
Add release notes for Pike
2017-07-26 10:45:15 +03:00
audit-versioned-notifications-api-bca7738e16954bad.yaml
add Ocata release notes
2017-01-26 14:03:12 +00:00
automatic-triggering-audit-8a9b0540d547db60.yaml
add Ocata release notes
2017-01-26 14:03:12 +00:00
background-jobs-ha-9d3cf3fe356f4705.yaml
Add release notes for Pike
2017-07-26 10:45:15 +03:00
blueprint-add-skip-actions-4a5a997dc1133f13.yaml
API changes for skipped actions: patch actions and status_message
2025-08-20 13:13:19 +02:00
bp-audit-scope-exclude-project-511a7720aac00dff.yaml
Exclude Project By Audit Scope
2018-04-20 08:47:07 +00:00
bp-extend-compute-model-attributes-b56bc093e8637bb4.yaml
Extend compute model attributes
2025-08-26 11:35:18 -03:00
bug-2098984-zone-migration-instance-not-found-b9ce947dd3e7e020.yaml
Fix zone migration instance not found issue
2025-09-16 16:12:35 -03:00
bug-2103451-fixes-prometheus-queries-with-multiple-target-0e65d20711d1abe2.yaml
Add support for pyproject.toml and wsgi module paths
2025-05-01 00:19:59 +00:00
bug-2109494-e5bf401767fa6cd6.yaml
Set keystone_client default interface to public
2025-05-09 08:16:51 +02:00
bug-2109722-cb205216d0c1a836.yaml
Allow volume and vm migrations in zone_migration
2025-09-16 12:20:18 +02:00
bug-2110947.yaml
Fix audit creation with no name and no goal or audit_template
2025-06-04 14:46:36 +02:00
bug-2112100-c1e56173cd29a35e.yaml
Check result of retype action based on type and status
2025-09-01 16:59:38 +02:00
bug-2112187-763bae283e0b736d.yaml
use cinder migrate for swap volume
2025-08-18 16:35:38 +00:00
bug-2113776-4bd314fb46623fbc.yaml
Use KiB as unit for host_ram_usage when using prometheus datasource
2025-06-19 16:25:27 +02:00
bug-2117726-fix-model-list-api-ref-30cc7ed1c85c0d0e.yaml
Fix api-ref doc for GET /infra-optim/v1/data_model
2025-08-12 09:47:01 -03:00
bug-2120586-fix-nova-microversion-check-9022a378b75d046f.yaml
Fix NovaHelper microversion comparison
2025-08-20 08:35:18 -03:00
bug-2121601-allow-status-message-updates-in-skipped-state-a8b4c5d7e9f2g3h1.yaml
Allow status_message updates for actions in SKIPPED state
2025-08-28 16:16:01 +01:00
build-baremetal-data-model-in-watcher-3023453a47b61dab.yaml
Add baremetal data model
2018-01-10 14:46:41 +08:00
cdm-scoping-8d9c307bad46bfa1.yaml
Update doc and add release note about cdm-scoping
2017-10-31 10:01:52 +09:00
centralise-config-opts-95670987dfbdb0e7.yaml
add Ocata release notes
2017-01-26 14:03:12 +00:00
change-ram-util-metric-4a3e6984b9dd968d.yaml
change ram util metric
2017-08-07 16:04:19 +08:00
check-strategy-requirements-66f9e9262412f8ec.yaml
Strategy requirements
2018-01-24 13:39:42 +03:00
cinder-model-integration-baa394a72a0a33bf.yaml
Cinder model integration
2017-07-05 08:55:10 +09:00
cluster-model-objects-wrapper-9c799ea262c56a5b.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
compute-cdm-include-all-instances-f7506ded2d57732f.yaml
filter exclude instances during migration
2018-02-23 03:13:46 +00:00
configurable-weights-default-planner-3746b33160bc7347.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
consume-nova-versioned-notifications-f98361b37e546b4d.yaml
update datamodel by nova notifications
2018-11-01 03:07:23 +00:00
continuously-optimization-35364f4d2c0b81fc.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
cors-e506801ebc0ed3f1.yaml
Fix missing CORS middleware
2025-09-13 11:49:11 +09:00
cron-based-continuous-audits-c3eedf28d9752b37.yaml
Add release notes for Pike
2017-07-26 10:45:15 +03:00
datasource-query-retry-00cba5f7e68aec39.yaml
Move datasource query_retry into baseclass.
2019-06-13 15:52:53 +02:00
db-migration-e1a705a8b54ccdd2.yaml
add Ocata release notes
2017-01-26 14:03:12 +00:00
decision-engine-threading-mode-26fc8066dcd499a2.yaml
Extend decision engine to support threading mode
2025-08-05 16:45:48 -03:00
define-the-audit-scope-e89edc5051dcf3f2.yaml
add Ocata release notes
2017-01-26 14:03:12 +00:00
deprecate-ceilometer-datasource-446b0be70fbce28b.yaml
Deprecate Ceilometer Datasource
2018-12-07 07:56:54 +00:00
deprecate-json-formatted-policy-file-3a92379e9f5dd203.yaml
[goal] Deprecate the JSON formatted policy file
2021-02-12 19:59:27 +00:00
deprecate-monasca-ds-9065f4d4bee09ab2.yaml
Deprecate Monasca data source
2025-02-16 18:45:31 +09:00
deprecate-noisy-neighbor-strat-7da910837ae8fa80.yaml
Deprecated Noisy Neighbor strategy
2025-05-12 15:44:39 -03:00
donot-run-host-migration-strategy-on-disabled-hosts-24084a22d4c8f914.yaml
Drop code from Host maintenance strategy migrating instance to disabled hosts
2025-05-14 09:24:25 +05:30
drop-operation-not-permitted-exception-14e49b35a3ca00d1.yaml
Fix release notes typo and extra information
2025-07-09 15:44:20 +05:30
drop-patch-delete-post-action-api-37fe4ce5be6500db.yaml
Fix release notes typo and extra information
2025-07-09 15:44:20 +05:30
drop-py39-8a9c99678b3e8eeb.yaml
finalize python 3.9 support removal
2025-07-21 18:25:04 +01:00
drop-py-2-7-54f8e806d71f19a7.yaml
[ussuri][goal] Drop python 2.7 support and testing
2019-11-16 14:55:01 +00:00
drop-python38-support-eeb19a0bc0160sw1.yaml
Update python versions, drop py3.8
2024-11-06 16:00:11 +01:00
drop-python-dateutil-dependency-2118404-f5a8b2c1e9d4a6b3.yaml
Replace dateutils usage with datetime and oslo.utils
2025-08-05 23:09:50 +05:30
dynamic-action-description-0e947b9e7ef2a134.yaml
dynamic action description
2017-07-26 20:42:01 -07:00
efficacy-indicator-95380ad7b84e3be2.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
enhance-watcher-applier-engine-86c676ce8f179e68.yaml
Enhance Watcher Applier Engine
2018-11-14 01:23:07 +00:00
event-driven-optimization-based-4870f112bef8a560.yaml
Add releasenote for event-driven-optimization-based
2020-02-04 03:46:32 +00:00
experimental-integrations-490d4cc32444288d.yaml
Add warning message for experimental integrations
2025-06-07 11:33:28 -03:00
file-based-metric-map-c2af62b5067895df.yaml
Allow using file to override metric map
2019-05-20 10:28:00 +02:00
fix-action-plan-state-on-failure-69e498d902ada5c5.yaml
Set actionplan state to FAILED if any action has failed
2025-05-26 14:58:03 +02:00
formal-datasource-interface-implementation-222769d55a127d33.yaml
Backwards compatibility for node parameter
2019-06-12 16:23:58 +00:00
general-purpose-decision-engine-threadpool-0711b23abfc9d409.yaml
[pre-commit] fix typos and configure codespell
2024-11-07 19:50:21 +00:00
get-goal-from-strategy-396c9b13a38bb650.yaml
Solve some spelling mistakes.
2016-11-23 11:40:51 +08:00
global-datasource-preference-3ab47b4be09ff3a5.yaml
Allow for global datasources preference from config
2019-05-09 11:02:15 +02:00
gnocchi-watcher-43c25d391fbd3e9c.yaml
Add release notes for Pike
2017-07-26 10:45:15 +03:00
grafana-datasource-b672367c23ffa0c6.yaml
Releasenote for grafana datasource
2019-07-02 10:20:49 +02:00
graph-based-cluster-model-523937a6f5e66537.yaml
add Ocata release notes
2017-01-26 14:03:12 +00:00
host-maintenance-strategy-41f640927948fb56.yaml
add strategy host_maintenance
2018-05-14 11:33:59 +00:00
host-maintenance-strategy-disable-migration-options-a2b72e32736e5446.yaml
Add options to disable migration in host maintenance
2025-08-20 22:32:33 +10:00
http_proxy_to_wsgi-81ab98b39038fb39.yaml
Add capability to parse forward headers
2025-09-11 15:50:04 +00:00
improve-compute-data-model-b427c85e4ed2b6fb.yaml
[pre-commit] fix typos and configure codespell
2024-11-07 19:50:21 +00:00
jsonschema-validation-79cab05d5295da00.yaml
Add release notes for Pike
2017-07-26 10:45:15 +03:00
make-monasca-client-optional-7e1a96b2ac902867.yaml
Make Monasca client optional and lazy-load
2025-08-28 16:53:48 +01:00
min-required-nova-train-71f124192d88ae52.yaml
Require nova_client.api_version >= 2.56
2019-05-23 15:49:19 -04:00
monasca-support-0b0486b8572ac38b.yaml
add Ocata release notes
2017-01-26 14:03:12 +00:00
multiple-global-efficacy-indicator-fc11c4844a12a7d5.yaml
Add missing release notes
2018-02-09 11:45:05 +03:00
node-resource-consolidation-73bc0c0abfeb0b03.yaml
node resource consolidation
2019-09-06 18:03:43 -07:00
noisy-neighbor-strategy-a71342740b59dddc.yaml
Fix a typo
2017-10-21 14:54:16 +08:00
notifications-actionplan-cancel-edb2a4a12543e2d0.yaml
Add missing release notes
2018-02-09 11:45:05 +03:00
optimization-threshold-21ad38f0470d0e1a.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
persistent-audit-parameters-ae41dd7252ba9672.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
planner-storage-action-plan-26ef37893c5e8648.yaml
add Ocata release notes
2017-01-26 14:03:12 +00:00
prometheus-datasource-e56f2f7b8f3427c2.yaml
Add prometheus data source for watcher decision engine
2025-01-10 15:20:37 +02:00
query-interval-not-query-timeout-ecb6f2c6b1a647e9.yaml
Rename confusing query timeout options
2025-08-27 23:22:45 +09:00
remove-ceilometer-datasource-8d9ab7d64d61e405.yaml
Remove ceilometer datasource
2024-12-16 23:51:27 +09:00
remove-dead-nova-helper-methods-62125e08.yaml
Remove dead NovaHelper methods
2025-10-08 11:53:01 +01:00
remove-glance-client-Yjk5ZDNh.yaml
Remove unused glance client integration
2025-10-08 11:53:01 +01:00
remove-neutron-client-42431931f1fe48a2.yaml
Remove dead neutron client code
2025-10-08 11:53:01 +01:00
remove-nova-legacy-notifications-e1b6d10eff58f30a.yaml
remove nova legacy notifications
2018-09-30 09:03:00 +08:00
replace-cold-migrate-to-use-nova-migration-api-cecd9a39ddd3bc58.yaml
Replace cold migration to use Nova migration API
2018-04-13 10:53:26 +09:00
request-id-fdfe63effd88be78.yaml
Fix missing X-OpenStack-Request-ID header
2025-09-11 15:46:21 +00:00
return-error-400-on-bad-parameters-bb964e4f5cadc15c.yaml
Return HTTP code 400 when creating an audit with wrong parameters
2025-05-16 09:35:50 +02:00
scope-for-data-model-ea9792f90db14343.yaml
releasenote for data model scope
2019-03-13 10:16:52 +08:00
service-versioned-notifications-api-70367b79a565d900.yaml
Add release notes for Pike
2017-07-26 10:45:15 +03:00
show-datamodel-api-6945b744fd5d25d5.yaml
Add releasenote about bp show-datamodel-api
2019-09-10 09:39:10 +08:00
stale-action-plan-b6a6b08df873c128.yaml
[pre-commit] Add initial pre-commit config
2024-10-22 20:12:53 +01:00
standard-deviation-strategy-cd1d0c443fdfde9c.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
storage_model_enabled_default-48c197f5a540956c.yaml
Enable storage model collector by default
2025-09-10 15:58:24 +02:00
storage-workload-balance-0ecabbc1791e6894.yaml
Add storage capacity balance Strategy
2018-01-18 22:18:18 -08:00
support-keystoneclient-option-b30d1ff45f86a2e7.yaml
support-keystoneclient-option
2019-05-18 18:36:19 +00:00
support-placement-api-58ce6bef1bbbe98a.yaml
Add Placement helper
2019-06-12 11:11:13 +08:00
suspended-audit-state-07f998c94e9d9a47.yaml
Added suspended audit state
2017-04-11 20:50:24 +09:00
uniform-airflow-strategy-68cdba1419c3f770.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
update-notification-topics-daf6303a63963ee9.yaml
Fix doc section to enable cinder notifications
2025-09-01 11:23:00 +02:00
uwsgi-support-8dcea6961e56dad0.yaml
Add uWSGI support
2019-06-27 14:56:52 +08:00
volume-migrate-action-fc57b0ce0e4c39ae.yaml
Add volume migrate action
2017-07-21 11:27:37 +09:00
watcher-notifications-ovo-7b44d52ef6400dd0.yaml
[pre-commit] fix typos and configure codespell
2024-11-07 19:50:21 +00:00
watcher-planner-selector-84d77549d46f362a.yaml
Watcher planner slector releasenote
2019-09-18 01:59:01 -07:00
watcher-policies-1e86a30f0f11c6fa.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
watcher-service-list-7b2f4b64f71e9b89.yaml
[pre-commit] fix typos and configure codespell
2024-11-07 19:50:21 +00:00
watcher-versioned-objects-fc5abf5c81c4590c.yaml
add Ocata release notes
2017-01-26 14:03:12 +00:00
wokload-stablization-strategy-name-9988e554ac2655a2.yaml
Update Overload standard deviation doc
2025-08-21 11:09:46 -04:00
workload-balance-base-on-cpu-or-ram-util-3ff4ee968c32b2ed.yaml
workload balance base on cpu or ram util
2017-08-09 07:04:10 +00:00
workload-balance-migration-strategy-a0b05148a57815c0.yaml
Add release notes for Newton blueprints
2016-08-29 12:56:02 +02:00
zone_migrate_src_type-642186730a4f354e.yaml
Use src_type to filter volumes in zone migration
2025-09-16 12:20:18 +02:00
zone-migration-missing-dst-node-bd0377af1f1ed245.yaml
Handle missing dst_pool parameter in zone_migration
2025-09-10 15:58:24 +02:00
zone-migration-strategy-10f7656a2a01e607.yaml
Add zone migration strategy
2018-01-24 19:33:22 +09:00
zone-migration-with-attached-volume-without-compute-nodes-ec4b1329e2b58279.yaml
Support zone migration audit without compute_nodes
2025-09-16 12:20:18 +02:00