openstack/yaql
Code Issues Proposed changes

Enable H202 assertRaises Exception too broad

Browse Source 
Change-Id: I49ff7f0c7b2edbd1a3c1a53ef2ffc95922db6f3b
This commit is contained in:
Ruslan Kamaldinov 2014-11-14 03:22:33 +03:00
parent 70ec163697
commit 281e1e9d39
2 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tox.ini
View File

@ -30,10 +30,9 @@ commands = python setup.py build_sphinx
# H404 multi line docstring should start with a summary
## TODO(ruhe) following checks should be fixed
# E721 do not compare types, use 'isinstance()'
# H202 assertRaises Exception too broad
# H306 imports not in alphabetical order
# H902 Use the 'not in' operator for collection membership evaluation
show-source = True
ignore = E123,E125,E721,H202,H306,H404,H803,H902
ignore = E123,E125,E721,H306,H404,H803,H902
builtins = _
exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build

27
yaql/tests/test_system.py
View File

@ -17,6 +17,7 @@ import unittest
from yaql.tests import YaqlTest
import yaql
from yaql.language.engine import parameter
from yaql.language.exceptions import YaqlExecutionException
class TestSystem(YaqlTest):
@ -45,9 +46,10 @@ class TestSystem(YaqlTest):
self.bar = value
foo = Foo(42)
self.assertRaises(Exception, self.eval, '$.foo.missing', foo)
self.assertRaises(Exception, self.eval, '$.foo.missing',
{'foo': 'bar'})
self.assertRaises(YaqlExecutionException,
self.eval, '$.foo.missing', foo)
self.assertRaises(YaqlExecutionException,
self.eval, '$.foo.missing', {'foo': 'bar'})
def test_int_bool_resolving(self):
@parameter('param', arg_type=types.IntType)
@ -72,18 +74,23 @@ class TestSystem(YaqlTest):
self.assertEquals("int: 1", self.eval('foo(1)', context=context1))
self.assertEquals("int: 0", self.eval('foo(0)', context=context1))
self.assertRaises(Exception, self.eval, "foo('1')", context=context1)
self.assertRaises(Exception, self.eval, 'foo(1)', context=context2)
self.assertRaises(YaqlExecutionException,
self.eval, "foo('1')", context=context1)
self.assertRaises(YaqlExecutionException,
self.eval, 'foo(1)', context=context2)
self.assertEquals("bool: True",
self.eval('foo(true)', context=context2))
self.assertEquals("bool: False",
self.eval('foo(false)', context=context2))
self.assertRaises(Exception, self.eval, "foo(1)", context=context2)
self.assertRaises(Exception, self.eval, 'foo(0)', context=context2)
self.assertRaises(Exception, self.eval, 'foo(True)', context=context2)
self.assertRaises(Exception, self.eval, "foo('true')",
context=context2)
self.assertRaises(YaqlExecutionException,
self.eval, "foo(1)", context=context2)
self.assertRaises(YaqlExecutionException,
self.eval, 'foo(0)', context=context2)
self.assertRaises(YaqlExecutionException,
self.eval, 'foo(True)', context=context2)
self.assertRaises(YaqlExecutionException,
self.eval, "foo('true')", context=context2)
self.assertEquals("int: 1", self.eval('foo(1)', context=context3))
self.assertEquals("int: 0", self.eval('foo(0)', context=context3))