openstack/zaqar
Code Issues Proposed changes

Register default claim and flavors policies in code

Browse Source 
This commit uses the existing policy-in-code module to move
all default policies for claims and flavors into code. This
commit also adds helpful documetation about each API those
policies protect, which will be generated in sample policy
files.

Change-Id: I7631658a441b2894d35fa0fe8fb55f706e657898
This commit is contained in:
gecong1973
2017-10-19 20:08:40 -07:00
committed by gecong
parent 68d2a6509d
commit 3f8ecba3d5
5 changed files with 153 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
etc/policy.json.sample
View File

@@ -1,12 +1,6 @@
{
"default": "rule:admin_or_owner",
"claims:get_all": "",
"claims:create": "",
"claims:get": "",
"claims:delete": "",
"claims:update": "",
"subscription:get_all": "",
"subscription:create": "",
"subscription:get": "",
@@ -20,12 +14,6 @@
"pools:delete": "rule:context_is_admin",
"pools:update": "rule:context_is_admin",
"flavors:get_all": "",
"flavors:create": "rule:context_is_admin",
"flavors:get": "",
"flavors:delete": "rule:context_is_admin",
"flavors:update": "rule:context_is_admin",
"ping:get": "",
"health:get": "rule:context_is_admin"
}

4
zaqar/common/policies/__init__.py
View File

@@ -13,6 +13,8 @@
import itertools
from zaqar.common.policies import base
from zaqar.common.policies import claims
from zaqar.common.policies import flavors
from zaqar.common.policies import messages
from zaqar.common.policies import queues
@@ -20,6 +22,8 @@ from zaqar.common.policies import queues
def list_rules():
return itertools.chain(
base.list_rules(),
claims.list_rules(),
flavors.list_rules(),
messages.list_rules(),
queues.list_rules()
)

69
zaqar/common/policies/claims.py Normal file
View File

@@ -0,0 +1,69 @@
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from oslo_policy import policy
from zaqar.common.policies import base
CLAIMS = 'claims:%s'
rules = [
policy.DocumentedRuleDefault(
name=CLAIMS % 'create',
check_str=base.UNPROTECTED,
description='Claims a set of messages from the specified queue.',
operations=[
{
'path': '/v2/queues/{queue_name}/claims',
'method': 'POST'
}
]
),
policy.DocumentedRuleDefault(
name=CLAIMS % 'get',
check_str=base.UNPROTECTED,
description='Queries the specified claim for the specified queue.',
operations=[
{
'path': '/v2/queues/{queue_name}/claims/{claim_id}',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=CLAIMS % 'delete',
check_str=base.UNPROTECTED,
description='Releases the specified claim for the specified queue.',
operations=[
{
'path': '/v2/queues/{queue_name}/claims/{claim_id}',
'method': 'DELETE'
}
]
),
policy.DocumentedRuleDefault(
name=CLAIMS % 'update',
check_str=base.UNPROTECTED,
description='Updates the specified claim for the specified queue.',
operations=[
{
'path': '/v2/queues/{queue_name}/claims/{claim_id}',
'method': 'PATCH'
}
]
)
]
def list_rules():
return rules

80
zaqar/common/policies/flavors.py Normal file
View File

@@ -0,0 +1,80 @@
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from oslo_policy import policy
from zaqar.common.policies import base
FLAVORS = 'flavors:%s'
rules = [
policy.DocumentedRuleDefault(
name=FLAVORS % 'get_all',
check_str=base.UNPROTECTED,
description='Lists flavors.',
operations=[
{
'path': '/v2/flavors',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=FLAVORS % 'create',
check_str=base.ROLE_ADMIN,
description='Creates a new flavor.',
operations=[
{
'path': '/v2/flavors/{flavor_name}',
'method': 'PUT'
}
]
),
policy.DocumentedRuleDefault(
name=FLAVORS % 'get',
check_str=base.UNPROTECTED,
description='Shows details for a flavor.',
operations=[
{
'path': '/v2/flavors/{flavor_name}',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=FLAVORS % 'delete',
check_str=base.ROLE_ADMIN,
description='Deletes the specified flavor.',
operations=[
{
'path': '/v2/flavors/{flavor_name}',
'method': 'DELETE'
}
]
),
policy.DocumentedRuleDefault(
name=FLAVORS % 'update',
check_str=base.ROLE_ADMIN,
description='Update flavor.',
operations=[
{
'path': '/v2/flavors/{flavor_name}',
'method': 'PATCH'
}
]
)
]
def list_rules():
return rules

12
zaqar/tests/etc/policy.json
View File

@@ -1,12 +1,6 @@
{
"default": "rule:admin_or_owner",
"claims:get_all": "",
"claims:create": "",
"claims:get": "",
"claims:delete": "",
"claims:update": "",
"subscription:get_all": "",
"subscription:create": "",
"subscription:get": "",
@@ -20,12 +14,6 @@
"pools:delete": "rule:context_is_admin",
"pools:update": "rule:context_is_admin",
"flavors:get_all": "",
"flavors:create": "rule:context_is_admin",
"flavors:get": "",
"flavors:delete": "rule:context_is_admin",
"flavors:update": "rule:context_is_admin",
"ping:get": "",
"health:get": "rule:context_is_admin"
}