performa/shaker
Code Issues Proposed changes

Use assertTrue/False instead of assertEqual(T/F)

Browse Source 
The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: Ic3351ec8748307085057160082e89cc7fe42eb7b
Closes-Bug:#1512207
This commit is contained in:
Swapnil Kulkarni (coolsvap)
2016-01-07 14:47:20 +05:30
parent e481305c5d
commit 969b7b7322
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shaker/tests/test_server.py
View File

@@ -126,14 +126,14 @@ class TestServerPlayScenario(testtools.TestCase):
for actual in output['records'].values():
has |= all(item in actual.items() for item in expected.items())
s = 'Output should contain record similar to: %s' % expected
self.assertEqual(True, has, message=s)
self.assertTrue(has, msg=s)
def assertNotContainsSimilarRecord(self, expected, output):
has = False
for actual in output['records'].values():
has |= all(item in actual.items() for item in expected.items())
s = 'Output should not contain record similar to: %s' % expected
self.assertEqual(False, has, message=s)
self.assertFalse(has, msg=s)
@mock.patch('shaker.engine.server.execute')
@mock.patch('shaker.engine.deploy.Deployment')

12
shaker/tests/test_sla.py
View File

@@ -22,16 +22,16 @@ from shaker.engine import sla
class TestSla(testtools.TestCase):
def test_eval(self):
self.assertEqual(2 ** 6, sla.eval_expr('2**6'))
self.assertEqual(True, sla.eval_expr('11 > a > 5', {'a': 7}))
self.assertTrue(sla.eval_expr('11 > a > 5', {'a': 7}))
self.assertEqual(42, sla.eval_expr('2 + a.b', {'a': {'b': 40}}))
self.assertEqual(True, sla.eval_expr('11 > 7 and 5 < 6'))
self.assertEqual(False, sla.eval_expr('(not 11 > 7) or (not 5 < 6)'))
self.assertTrue(sla.eval_expr('11 > 7 and 5 < 6'))
self.assertFalse(sla.eval_expr('(not 11 > 7) or (not 5 < 6)'))
def test_eval_regex(self):
self.assertEqual(True, sla.eval_expr('"some text" & "\w+\s+\w+"'))
self.assertEqual(False, sla.eval_expr('"some text" & "\d+"'))
self.assertTrue(sla.eval_expr('"some text" & "\w+\s+\w+"'))
self.assertFalse(sla.eval_expr('"some text" & "\d+"'))
self.assertEqual(False, sla.eval_expr('a & "\d+"', {'a': ''}))
self.assertFalse(sla.eval_expr('a & "\d+"', {'a': ''}))
def test_eval_non_existent_ref(self):
self.assertRaises(sla.SLAException, sla.eval_expr,