stackforge/cookbook-pacemaker
Code Issues Proposed changes

make pacemaker_vip_primitive more defensive

Browse Source 
Currently we are seeing pacemaker_vip_primitive occasionally
generate NoMethodError exceptions like:

  undefined method `[]' for nil:NilClass

Clearly we need more helpful error messages when things go wrong.
This commit is contained in:
Adam Spiers
2014-04-04 11:48:53 +01:00
parent dabbb24445
commit 220389b697
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
definitions/pacemaker_vip_primitive.rb
View File

@@ -1,6 +1,12 @@
define :pacemaker_vip_primitive, :cb_network => nil, :hostname => nil, :domain => nil, :op => nil do
net_db = data_bag_item('crowbar', "#{params[:cb_network]}_network")
ip_addr = net_db["allocated_by_name"]["#{params[:hostname]}.#{params[:domain]}"]["address"]
network = params[:cb_network]
net_db = data_bag_item('crowbar', "#{network}_network")
raise "#{network}_network data bag missing?!" unless net_db
fqdn = "#{params[:hostname]}.#{params[:domain]}"
unless net_db["allocated_by_name"][fqdn]
raise "Missing allocation for #{fqdn} in #{network} network"
end
ip_addr = net_db["allocated_by_name"][fqdn]["address"]
primitive_name = "#{params[:hostname]}-vip-#{params[:cb_network]}"