stackforge/cookbook-pacemaker
Code Issues Proposed changes

rename Pacemaker::CIBObject::type to ::definition_type

Browse Source 
Clarify that this class method is for extracting the type from a
definition string, not for obtaining the native type of the class.
This commit is contained in:
Adam Spiers
2014-03-14 19:56:09 +00:00
parent 1db1036cae
commit ea9079581e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/pacemaker/cib_object.rb
View File

@@ -26,7 +26,7 @@ module Pacemaker
end
end
def type(definition)
def definition_type(definition)
unless definition =~ /\A(\w+)\s/
raise "Couldn't extract CIB object type from '#{definition}'"
end
@@ -50,7 +50,7 @@ module Pacemaker
this_class = method(__method__).owner
if calling_class == this_class
# Invoked via (this) base class
obj_type = type(definition)
obj_type = definition_type(definition)
subclass = @@subclasses[obj_type]
unless subclass
raise "No subclass of #{self.name} was registered with type '#{obj_type}'"
@@ -118,7 +118,7 @@ module Pacemaker
end
def type
self.class.type(definition)
self.class.definition_type(definition)
end
def to_s