stackforge/openstack-sdk-php
Code Issues Proposed changes

Updating unit tests, removing syslog calls.

Browse Source
This commit is contained in:
Matt Butcher
2012-01-19 17:38:51 -06:00
parent 7af6bc580d
commit 49cc5bbb57
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/HPCloud/Storage/ObjectStorage/Container.php
View File

@@ -404,7 +404,6 @@ class Container implements \Countable, \IteratorAggregate {
hash_update_stream($hash, $file);
$etag = hash_final($hash);
$headers['ETag'] = $etag;
syslog(LOG_WARNING, 'ETag: ' . $etag);
// Not sure if this is necessary:
rewind($file);

5
test/Tests/StreamWrapperTest.php
View File

@@ -265,14 +265,14 @@ class StreamWrapperTest extends \HPCloud\Tests\TestCase {
*/
public function testClose($res) {
$this->assertTrue(is_resource($res));
fwrite($res, 'extra.');
fwrite($res, '~~~~');
//throw new \Exception(stream_get_contents($res));
fflush($res);
// This is occasionally generating seemingly
// spurious PHP errors about Bootstrap::$config.
fclose($res);
/*
$url = $this->newUrl(self::FNAME);
$res2 = fopen($url, 'r', FALSE, $this->basicSwiftContext());
$this->assertTrue(is_resource($res2));
@@ -280,7 +280,6 @@ class StreamWrapperTest extends \HPCloud\Tests\TestCase {
$contents = stream_get_contents($res2);
fclose($res2);
$this->assertRegExp('/~{4}$/', $contents);
*/
}