Fix missing and misspelled parameters

Missing parameters:
  * vncserver_listen (openstack::all)
  * setup_test_volume (openstack::all)
Misspelled parameters:
  * quantum_db_name (openstack::all)
  * rabbit_virtual_host (openstack::cinder::all,controller)

Change-Id: Id0116981bf4693b324bb2ef4255175f05c024824

manifests/all.pp

@@ -177,6 +177,7 @@ class openstack::all (
   # VNC
   $vnc_enabled             = true,
   $vncproxy_host           = false,
+  $vncserver_listen        = false,
   # cinder
   # if the cinder management components should be installed
   $cinder                  = true,
@@ -184,6 +185,7 @@ class openstack::all (
   $cinder_db_dbname        = 'cinder',
   $cinder_bind_address     = '0.0.0.0',
   $manage_volumes          = true,
+  $setup_test_volume       = false,
   $volume_group            = 'cinder-volumes',
   $iscsi_ip_address        = '127.0.0.1',
   # Quantum
@@ -270,7 +272,7 @@ class openstack::all (
       quantum                => $quantum,
       quantum_db_user        => $quantum_db_user,
       quantum_db_password    => $quantum_db_password,
-      quantum_db_dbname      => $quantum_db_dbname,
+      quantum_db_dbname      => $quantum_db_name,
       allowed_hosts          => $allowed_hosts,
       enabled                => $enabled,
     }

manifests/cinder/all.pp

@@ -49,7 +49,7 @@ class openstack::cinder::all(
     rabbit_host         => $rabbit_host,
     rabbit_port         => $rabbit_port,
     rabbit_hosts        => $rabbit_hosts,
-    rabbit_virtual_host => $cinder_rabbit_virtual_host,
+    rabbit_virtual_host => $rabbit_virtual_host,
     package_ensure      => $package_ensure,
     api_paste_config    => $api_paste_config,
     verbose             => $verbose,

manifests/cinder/controller.pp

@@ -47,7 +47,7 @@ class openstack::cinder::controller(
     rabbit_host         => $rabbit_host,
     rabbit_port         => $rabbit_port,
     rabbit_hosts        => $rabbit_hosts,
-    rabbit_virtual_host => $cinder_rabbit_virtual_host,
+    rabbit_virtual_host => $rabbit_virtual_host,
     package_ensure      => $package_ensure,
     api_paste_config    => $api_paste_config,
     verbose             => $verbose,

manifests/controller.pp

@@ -249,7 +249,7 @@ class openstack::controller (
       quantum                => $quantum,
       quantum_db_user        => $quantum_db_user,
       quantum_db_password    => $quantum_db_password,
-      quantum_db_dbname      => $quantum_db_dbname,
+      quantum_db_dbname      => $quantum_db_name,
       allowed_hosts          => $allowed_hosts,
       enabled                => $enabled,
     }

spec/classes/openstack_all_spec.rb

@@ -390,7 +390,7 @@ describe 'openstack::all' do
         :fixed_range       => '10.0.0.0/24',
         :floating_range    => false,
         :network_manager   => 'nova.network.manager.FlatDHCPManager',
-        :config_overrides  => '',
+        :config_overrides  => {},
         :create_networks   => true,
         :enabled           => true,
         :install_service   => true