stackforge/puppet-openstack
Code Issues Proposed changes

Fix missing and misspelled parameters

Browse Source 
Missing parameters:
  * vncserver_listen (openstack::all)
  * setup_test_volume (openstack::all)
Misspelled parameters:
  * quantum_db_name (openstack::all)
  * rabbit_virtual_host (openstack::cinder::all,controller)

Change-Id: Id0116981bf4693b324bb2ef4255175f05c024824
This commit is contained in:
Mathieu Gagné
2013-07-01 21:27:09 -04:00
parent 3c0fd00fe9
commit 0f6398f244
5 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/all.pp
View File

@@ -177,6 +177,7 @@ class openstack::all (
# VNC # VNC
$vnc_enabled = true, $vnc_enabled = true,
$vncproxy_host = false, $vncproxy_host = false,
$vncserver_listen = false,
# cinder # cinder
# if the cinder management components should be installed # if the cinder management components should be installed
$cinder = true, $cinder = true,
@@ -184,6 +185,7 @@ class openstack::all (
$cinder_db_dbname = 'cinder', $cinder_db_dbname = 'cinder',
$cinder_bind_address = '0.0.0.0', $cinder_bind_address = '0.0.0.0',
$manage_volumes = true, $manage_volumes = true,
$setup_test_volume = false,
$volume_group = 'cinder-volumes', $volume_group = 'cinder-volumes',
$iscsi_ip_address = '127.0.0.1', $iscsi_ip_address = '127.0.0.1',
# Quantum # Quantum
@@ -270,7 +272,7 @@ class openstack::all (
quantum => $quantum, quantum => $quantum,
quantum_db_user => $quantum_db_user, quantum_db_user => $quantum_db_user,
quantum_db_password => $quantum_db_password, quantum_db_password => $quantum_db_password,
quantum_db_dbname => $quantum_db_dbname, quantum_db_dbname => $quantum_db_name,
allowed_hosts => $allowed_hosts, allowed_hosts => $allowed_hosts,
enabled => $enabled, enabled => $enabled,
} }

2
manifests/cinder/all.pp
View File

@@ -49,7 +49,7 @@ class openstack::cinder::all(
rabbit_host => $rabbit_host, rabbit_host => $rabbit_host,
rabbit_port => $rabbit_port, rabbit_port => $rabbit_port,
rabbit_hosts => $rabbit_hosts, rabbit_hosts => $rabbit_hosts,
rabbit_virtual_host => $cinder_rabbit_virtual_host, rabbit_virtual_host => $rabbit_virtual_host,
package_ensure => $package_ensure, package_ensure => $package_ensure,
api_paste_config => $api_paste_config, api_paste_config => $api_paste_config,
verbose => $verbose, verbose => $verbose,

2
manifests/cinder/controller.pp
View File

@@ -47,7 +47,7 @@ class openstack::cinder::controller(
rabbit_host => $rabbit_host, rabbit_host => $rabbit_host,
rabbit_port => $rabbit_port, rabbit_port => $rabbit_port,
rabbit_hosts => $rabbit_hosts, rabbit_hosts => $rabbit_hosts,
rabbit_virtual_host => $cinder_rabbit_virtual_host, rabbit_virtual_host => $rabbit_virtual_host,
package_ensure => $package_ensure, package_ensure => $package_ensure,
api_paste_config => $api_paste_config, api_paste_config => $api_paste_config,
verbose => $verbose, verbose => $verbose,

2
manifests/controller.pp
View File

@@ -249,7 +249,7 @@ class openstack::controller (
quantum => $quantum, quantum => $quantum,
quantum_db_user => $quantum_db_user, quantum_db_user => $quantum_db_user,
quantum_db_password => $quantum_db_password, quantum_db_password => $quantum_db_password,
quantum_db_dbname => $quantum_db_dbname, quantum_db_dbname => $quantum_db_name,
allowed_hosts => $allowed_hosts, allowed_hosts => $allowed_hosts,
enabled => $enabled, enabled => $enabled,
} }

2
spec/classes/openstack_all_spec.rb
View File

@@ -390,7 +390,7 @@ describe 'openstack::all' do
:fixed_range => '10.0.0.0/24', :fixed_range => '10.0.0.0/24',
:floating_range => false, :floating_range => false,
:network_manager => 'nova.network.manager.FlatDHCPManager', :network_manager => 'nova.network.manager.FlatDHCPManager',
:config_overrides => '', :config_overrides => {},
:create_networks => true, :create_networks => true,
:enabled => true, :enabled => true,
:install_service => true :install_service => true