stackforge/puppet-openstack
Code Issues Proposed changes

Fix typo with vncserver_listen and internal_address

Browse Source 
If vncserver_listen is not set, it should properly fall back to
internal_address_real.

This fixes an issue with libvirt trying to resolve 'False' as a
hostname:

   getaddrinfo(False,5900): Name or service not known

Change-Id: I072aceb4e61c8714b3b0d272c19d10e295fc2eae
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
This commit is contained in:
Paul Belanger
2013-09-23 16:08:53 -04:00
parent c0d90a2e8a
commit 19fc83307f
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/all.pp
View File

@@ -248,7 +248,7 @@ class openstack::all (
if $vncserver_listen { if $vncserver_listen {
$vncserver_listen_real = $vncserver_listen $vncserver_listen_real = $vncserver_listen
} else { } else {
$vncserver_listen_real = $internal_address $vncserver_listen_real = $internal_address_real
} }
if $glance_api_servers { if $glance_api_servers {
$glance_api_servers_real = $glance_api_servers $glance_api_servers_real = $glance_api_servers

2
spec/classes/openstack_all_spec.rb
View File

@@ -343,7 +343,7 @@ describe 'openstack::all' do
it 'should have nova::compute::libvirt configured' do it 'should have nova::compute::libvirt configured' do
should contain_class('nova::compute::libvirt').with( should contain_class('nova::compute::libvirt').with(
:libvirt_type => 'kvm', :libvirt_type => 'kvm',
:vncserver_listen => false, :vncserver_listen => '10.0.0.1',
:migration_support => false :migration_support => false
) )
end end