stackforge/python-libraclient
Code Issues Proposed changes

Update patch set 21

Browse Source 
Patch Set 21: I would prefer that you didn't merge this

(3 inline comments)

A few in-line comments of first pass

Patch-set: 21
Label: Code-Review=-1
Label: Workflow=0
This commit is contained in:
Gerrit User 2325
2013-10-31 11:14:52 +00:00
committed by Gerrit Code Review
parent 8e1f4d071f
commit 0985d4e26b
1 changed files with 55 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
dbb9c8605dc2912ed932576cd933bd296b05cbb7 Normal file
View File

@@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "AAAATn//njE\u003d",
"filename": "libraclient/openstack/__init__.py",
"patchSetId": 21
},
"lineNbr": 1,
"author": {
"id": 2325
},
"writtenOn": "2013-10-31T11:14:52Z",
"side": 1,
"message": "Not our copyright in this dir",
"revId": "dbb9c8605dc2912ed932576cd933bd296b05cbb7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn//niw\u003d",
"filename": "libraclient/openstack/common/__init__.py",
"patchSetId": 21
},
"lineNbr": 2,
"author": {
"id": 2325
},
"writtenOn": "2013-10-31T11:14:52Z",
"side": 1,
"message": "And again",
"revId": "dbb9c8605dc2912ed932576cd933bd296b05cbb7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATn//niI\u003d",
"filename": "libraclient/v1_1/base.py",
"patchSetId": 21
},
"lineNbr": 1,
"author": {
"id": 2325
},
"writtenOn": "2013-10-31T11:14:52Z",
"side": 1,
"message": "Missing copyright",
"revId": "dbb9c8605dc2912ed932576cd933bd296b05cbb7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}