Tests: PEP-257 checks

This uses the latest, patched libraries for:
- pep257
- hacking
- pep8
- flake8_docstring

Most of the updates are in pending patch requests
to upstream repositories.

Change-Id: I73de7229cf5fc0c66c53c4a5ca0bba702ebde619

satori/__init__.py

@@ -11,6 +11,8 @@
 #   under the License.
 #
 
+"""Satori main module."""
+
 __all__ = ['__version__']
 
 import pbr.version

satori/discovery.py

@@ -10,8 +10,7 @@
 #   License for the specific language governing permissions and limitations
 #   under the License.
 #
-"""Discovery Module
-
+"""Discovery Module.
 
     TODO(zns): testing, refactoring, etc...  just using this to demonstrate
     functionality
@@ -20,8 +19,6 @@ Example usage:
 
     from satori import discovery
     discovery.run(address="foo.com")
-
-
 """
 
 from __future__ import print_function

satori/errors.py

@@ -32,4 +32,5 @@ class SatoriException(Exception):
 
 
 class SatoriInvalidNetloc(SatoriException):
+
     """Netloc that cannot be parsed by `urlparse`."""

satori/sysinfo/facter.py

@@ -2,4 +2,5 @@
 
 
 def get_systeminfo(resource, config):
+    """."""
     return {'facter': 'is better'}

satori/sysinfo/ohai.py

@@ -2,4 +2,5 @@
 
 
 def get_systeminfo(resource, config):
+    """."""
     return {'ohai': 'there!'}

test-requirements.txt

@@ -1,4 +1,20 @@
-hacking>=0.8.0,<0.9
+# pep8 with support for empty files through flake8
+-e git://github.com/ziadsawalha/pep8.git@19b64e1d6b52cb814e482188369f4db24e0e82c2#egg=pep8
+
+# pep257 tool with fix for updated PEP-257 and __all__ as a list
+# Two PR pending to upstream
+-e git://github.com/ziadsawalha/pep257.git@7752b1c9977e5dfca70f7635e5bfc12442c540a6#egg=pep257
+
+# PEP-257 plugin for flake8 with pending upstream change for support for latest pep257 tool
+#
+# Should be -e hg+https://bitbucket.org/ziadsawalha/flake8-docstrings@51864b0e7451bc0a43ab6fb0303e8a69961cb401#egg=flake8-docstring
+# ... but mercurial (hg) doesn't seem to be installed on openstack infrastructure. So, using a github temporary fork
+-e git://github.com/ziadsawalha/flake8_docstrings@v0.1.5#egg=flake8-docstring
+
+# Newer hacking
+# Includes two fixes for handling blank lines in files and for handling egg-linked libraries
+-e git://github.com/ziadsawalha/hacking.git@76ff3d0c8b116df147b7e4ca00afda67a9537f2a#egg=hacking
+
 
 coverage>=3.6
 discover

tox.ini

@@ -26,4 +26,4 @@ downloadcache = ~/cache/pip
 [flake8]
 ignore = E126,E202,W602,H302,H402
 show-source = True
-exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,satori/contrib,*.ropeproject
+exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,*satori/contrib*,*.ropeproject,*satori/tests*,setup.py