starlingx/distcloud-client
Code Issues Proposed changes
214e2679bd
distcloud-client/f83fe08336349267b7b2d09638cf7ab9eb90a55f
Gerrit User 31954 33d134fa56 Update patch set 9 
Patch Set 9:

(3 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 35441 \u003c35441@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31954\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31954 \u003c31954@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31954\u003e replied on the change"}
2024-05-06 18:17:53 +00:00

351 lines
11 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "5fa25aa9_e71058e1",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 14675
},
"writtenOn": "2024-04-17T13:54:55Z",
"side": 1,
"message": "Create tests, please.",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a6a1040e_594e1d87",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 36476
},
"writtenOn": "2024-04-17T14:16:43Z",
"side": 1,
"message": "Hugo, did you mean to create this as resolved? I\u0027ve removed it just in case.",
"parentUuid": "5fa25aa9_e71058e1",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ae0b2d03_6aa6532a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 31954
},
"writtenOn": "2024-04-22T14:46:19Z",
"side": 1,
"message": "I would expect the enroll in phase operation also need the",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bfc12de5_90436f8c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 35441
},
"writtenOn": "2024-04-24T18:48:34Z",
"side": 1,
"message": "Done",
"parentUuid": "a6a1040e_594e1d87",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4cd15a9e_a1549be2",
"filename": "distributedcloud-client/dcmanagerclient/api/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 87,
"author": {
"id": 36476
},
"writtenOn": "2024-04-17T14:16:11Z",
"side": 1,
"message": "nit: since this call structure is repeated in each method, why don\u0027t we improve the code in _deploy_operation by moving the data and files retrieval there if it isn\u0027t specified?",
"range": {
"startLine": 83,
"startChar": 0,
"endLine": 87,
"endChar": 71
},
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "13e2df9c_62c4b672",
"filename": "distributedcloud-client/dcmanagerclient/api/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 87,
"author": {
"id": 35441
},
"writtenOn": "2024-04-23T13:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "4cd15a9e_a1549be2",
"range": {
"startLine": 83,
"startChar": 0,
"endLine": 87,
"endChar": 71
},
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cf951d93_7f2652f5",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 11,
"author": {
"id": 36476
},
"writtenOn": "2024-04-17T14:16:11Z",
"side": 1,
"message": "nit: this is not directly related to your changes, so it\u0027s okay if we do it later.\nInstead of importing the whole file, we should import only DCManagerShowOne",
"range": {
"startLine": 11,
"startChar": 40,
"endLine": 11,
"endChar": 44
},
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ec35e702_9dbfae7c",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 11,
"author": {
"id": 35441
},
"writtenOn": "2024-04-23T13:08:01Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "cf951d93_7f2652f5",
"range": {
"startLine": 11,
"startChar": 40,
"endLine": 11,
"endChar": 44
},
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "036cd9dd_286611f9",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 561,
"author": {
"id": 31954
},
"writtenOn": "2024-04-22T14:37:39Z",
"side": 1,
"message": "Request install values and deploy values as well",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e3664711_23cbd33f",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 561,
"author": {
"id": 31954
},
"writtenOn": "2024-04-22T14:46:19Z",
"side": 1,
"message": "Sorry for my mistake, the deploy config should not be necessary, but the install values, BMC password should be expected to have for the factory install the subclouds, I would @kyle and @salman to comment on this topic",
"parentUuid": "036cd9dd_286611f9",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1550aeaf_173ab9d3",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 561,
"author": {
"id": 35441
},
"writtenOn": "2024-04-23T13:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "e3664711_23cbd33f",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "768b908c_58e88e21",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 561,
"author": {
"id": 35315
},
"writtenOn": "2024-04-29T12:41:03Z",
"side": 1,
"message": "Don\u0027t really get why we would need install values here. My understanding is that when it\u0027s time to run enrolment, the subcloud would already be installed, and what the enrolment phase would do is just run the new enroll playbook and leave the deploy state as \"enroll-complete\" leaving the configuration to be done by deploy config or manually (and then running deploy complete).",
"parentUuid": "1550aeaf_173ab9d3",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a38eeb2c_5ba5ce33",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 561,
"author": {
"id": 31954
},
"writtenOn": "2024-05-06T18:17:53Z",
"side": 1,
"message": "We\u0027ll need the bmc address and bmc password to make a request to the bmc controller to feed the seed iso",
"parentUuid": "768b908c_58e88e21",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f0db13b6_fee28bf1",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 565,
"author": {
"id": 36476
},
"writtenOn": "2024-04-17T14:16:11Z",
"side": 1,
"message": "YAML file containing **the** parameters required for the **subcloud** enrollment.",
"range": {
"startLine": 564,
"startChar": 18,
"endLine": 565,
"endChar": 29
},
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "704e8de8_621fd7b0",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 565,
"author": {
"id": 35441
},
"writtenOn": "2024-04-23T13:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "f0db13b6_fee28bf1",
"range": {
"startLine": 564,
"startChar": 18,
"endLine": 565,
"endChar": 29
},
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b070393f_7372e70f",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 604,
"author": {
"id": 36476
},
"writtenOn": "2024-04-17T14:16:11Z",
"side": 1,
"message": "This code is duplicated in this file. I suggest creating a common method to do this operation, if possible.",
"range": {
"startLine": 597,
"startChar": 0,
"endLine": 604,
"endChar": 82
},
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "db5225b5_9f0fabf4",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 604,
"author": {
"id": 35441
},
"writtenOn": "2024-04-23T13:08:01Z",
"side": 1,
"message": "Done",
"parentUuid": "b070393f_7372e70f",
"range": {
"startLine": 597,
"startChar": 0,
"endLine": 604,
"endChar": 82
},
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink