starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(5 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 33549 \u003c33549@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33549\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31954 \u003c31954@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33549\u003e replied on the change"}
This commit is contained in:
Gerrit User 33549 2024-05-14 12:02:41 +00:00 committed by Gerrit Code Review
parent 025f6ca262
commit 522d93b8ad
1 changed files with 116 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

116
fe788ab14f480cf06dab518440c8ac28ab0c453f
View File

@ -102,6 +102,122 @@
},
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "95be3b3d_e9f48493",
"filename": "distributedcloud/dccommon/subcloud_enrollment.py",
"patchSetId": 9
},
"lineNbr": 77,
"author": {
"id": 33549
},
"writtenOn": "2024-05-14T12:02:41Z",
"side": 1,
"message": "My understanding is that we have to support a custom password for this feature.",
"parentUuid": "a85654d4_95477acf",
"range": {
"startLine": 77,
"startChar": 24,
"endLine": 77,
"endChar": 38
},
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9aef14df_8fed6037",
"filename": "distributedcloud/dccommon/subcloud_enrollment.py",
"patchSetId": 9
},
"lineNbr": 100,
"author": {
"id": 33549
},
"writtenOn": "2024-05-14T12:02:41Z",
"side": 1,
"message": "If you want this top-level log, then you should include the self.name to identify the subcloud",
"range": {
"startLine": 100,
"startChar": 12,
"endLine": 100,
"endChar": 16
},
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6f5595b5_365d6fc3",
"filename": "distributedcloud/dccommon/subcloud_enrollment.py",
"patchSetId": 9
},
"lineNbr": 105,
"author": {
"id": 33549
},
"writtenOn": "2024-05-14T12:02:41Z",
"side": 1,
"message": "This is expected isn\u0027t it? If so, it could probably be debug level? It\u0027s getting into the noise territory at info level.",
"range": {
"startLine": 105,
"startChar": 16,
"endLine": 105,
"endChar": 20
},
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5c0662da_0f6e7b8e",
"filename": "distributedcloud/dccommon/subcloud_enrollment.py",
"patchSetId": 9
},
"lineNbr": 117,
"author": {
"id": 33549
},
"writtenOn": "2024-05-14T12:02:41Z",
"side": 1,
"message": "Include self.name in the log msg",
"range": {
"startLine": 117,
"startChar": 16,
"endLine": 117,
"endChar": 25
},
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0b40039e_6c57bc27",
"filename": "distributedcloud/dccommon/subcloud_enrollment.py",
"patchSetId": 9
},
"lineNbr": 132,
"author": {
"id": 33549
},
"writtenOn": "2024-05-14T12:02:41Z",
"side": 1,
"message": "Include self.name in log. You could probably lose the \u0027gen_seed_iso_command\u0027 text as well without losing any information. \n\nThe self.name comment also applies to the LOG.info and LOG.error message following this run command.",
"range": {
"startLine": 132,
"startChar": 8,
"endLine": 132,
"endChar": 73
},
"revId": "fe788ab14f480cf06dab518440c8ac28ab0c453f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}