starlingx/distcloud
Code Issues Proposed changes

Remove deprecated alarm 250.002 from unit tests

Browse Source 
Alarm 250.002 is deprecated. As alarm 250.002 is being
used in an unit test, this review removes alarm 250.002
from usage.

Changed from alarm 250.002 to alarm 250.001. Both
alarms have the same characterists:
    Severity: major
    Degraded Affecting Severity: none
    Management Affecticting Severity: warning

Alarm ID: 250.002. Alarm message: "<hostname> Ceph cache
tiering configuration is out-of-date"
Alarm ID: 250.001. Alarm message: "<hostname> Configuration
is out-of-date."

Test Plan:
Pass: Executed 'tox -e py39' and unit tests continued to pass

Closes-Bug: 2023663

Change-Id: I3d12799e7697172699beba46986764daa105433e
Signed-off-by: Mauricio Carmelo <Mauricio.BiasiDoMonteCarmelo@windriver.com>
This commit is contained in:
Mauricio Carmelo 2023-06-13 09:12:00 -04:00
parent 7debe0f8ef
commit 79648a9695
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
distributedcloud/dcmanager/tests/unit/orchestrator/states/kube/test_pre_check.py
View File

@ -61,7 +61,7 @@ KUBERNETES_UPGRADE_HEALTH_RESPONSE_NON_MGMT_AFFECTING_ALARM = \
MEMORY_THRESHOLD_ALARM = FakeAlarm('100.101', 'True')
KUBERNETES_UPGRADE_ALARM = FakeAlarm('900.007', 'True')
CEPH_ALARM = FakeAlarm('250.002', 'False')
CONFIG_OUT_OF_DATE_ALARM = FakeAlarm('250.001', 'False')
class TestKubeUpgradePreCheckStage(TestKubeUpgradeState):
@ -146,7 +146,7 @@ class TestKubeUpgradePreCheckStage(TestKubeUpgradeState):
self.subcloud.id,
deploy_status=DEPLOY_STATE_DONE)
self.fm_client.get_alarms.return_value = [CEPH_ALARM, KUBERNETES_UPGRADE_ALARM]
self.fm_client.get_alarms.return_value = [CONFIG_OUT_OF_DATE_ALARM, KUBERNETES_UPGRADE_ALARM]
self.sysinv_client.get_kube_upgrade_health.return_value = KUBERNETES_UPGRADE_HEALTH_RESPONSE_MGMT_AFFECTING_ALARM
self.sysinv_client.get_kube_upgrades.return_value = [FakeKubeUpgrade()]
self.sysinv_client.get_kube_versions.return_value = [