starlingx/integ
Code Issues Proposed changes

Fix use of ceph_mgr_lifecycle_days variable

Browse Source 
The change [1] added a syntax issue where it was not
possible to use the variable ceph_mgr_lifecycle_days.

Analyzing the code, it was possible to observe that
the ceph_mgr_lifecycle_days variable is part of the
Config class, not of the ServiceMonitor.

So to fix the problem, just replace the use of
'self' with CONFIG.

Test Plan:
  PASS: AIO-SX fresh install
  PASS: Notice that there are no errors in the
        log /var/log/mgr-restful-plugin.log

Closes-Bug: 2023553

[1]: https://review.opendev.org/c/starlingx/integ/+/885881

Change-Id: Icb46f1589057607e24123b69e9ab44994580585a
Signed-off-by: Erickson Silva de Oliveira <Erickson.SilvadeOliveira@windriver.com>
This commit is contained in:
Erickson Silva de Oliveira
2023-07-04 14:29:37 +00:00
parent bd0a8e444c
commit 2737967430
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ceph/ceph/files/mgr-restful-plugin.py
View File

@@ -578,8 +578,8 @@ class ServiceMonitor(object):
# REST API should be available now
# start making periodic requests (ping)
while True:
if self.ceph_mgr_lifecycle_days != -1 \
and self.ceph_mgr_uptime() >= self.ceph_mgr_lifecycle_days:
if CONFIG.ceph_mgr_lifecycle_days != -1 \
and self.ceph_mgr_uptime() >= CONFIG.ceph_mgr_lifecycle_days:
self.ceph_mgr_start_date = None
LOG.info("Restarting ceph-mgr to control RSS memory growth")
self.ceph_mgr_restart()