starlingx
/
metal
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(3 comments)

Patch-set: 7
Reviewer: Gerrit User 32933 <32933@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 32933 \u003c32933@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926 2024-03-26 13:26:17 +00:00 committed by Gerrit Code Review
parent 6d125e22c5
commit 08ea092e4f
1 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
a44610b90605ad3bacd8c36141098c43c59ee087 Normal file
View File

@ -0,0 +1,61 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "5449bdca_e94d00ca",
"filename": "mtce-common/src/common/nodeBase.h",
"patchSetId": 7
},
"lineNbr": 1221,
"author": {
"id": 9926
},
"writtenOn": "2024-03-26T13:26:17Z",
"side": 1,
"message": "in case of future upgrades, do these messages need to be versioned? or is versioning related to mtc_cmd.ver ?",
"revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1b464e22_aa998eef",
"filename": "mtce-common/src/common/nodeUtil.cpp",
"patchSetId": 7
},
"lineNbr": 1915,
"author": {
"id": 9926
},
"writtenOn": "2024-03-26T13:26:17Z",
"side": 1,
"message": "is the else of this an error condition?",
"range": {
"startLine": 1915,
"startChar": 5,
"endLine": 1915,
"endChar": 9
},
"revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "380579a7_e20258f2",
"filename": "mtce/src/common/nodeClass.cpp",
"patchSetId": 7
},
"lineNbr": 3553,
"author": {
"id": 9926
},
"writtenOn": "2024-03-26T13:26:17Z",
"side": 1,
"message": "filestream.close() ?",
"revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}