starlingx
/
metal
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: -Code-Review

(1 comment)

Patch-set: 5
Label: Code-Review=0, 010807a91648562e93cf3ded9f953a4ea7f06598
Attention: {"person_ident":"Gerrit User 36205 \u003c36205@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34119\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34119 \u003c34119@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34119\u003e replied on the change"}
This commit is contained in:
Gerrit User 34119 2024-05-06 20:39:31 +00:00 committed by Gerrit Code Review
parent 4a94e86661
commit 6050d71580
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
8c8f44fe009b70b01bfd1c3b77d9d3d938a219b6
View File

@ -51,6 +51,24 @@
"parentUuid": "d252bd3c_c9d80298",
"revId": "8c8f44fe009b70b01bfd1c3b77d9d3d938a219b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3e6d03fb_db838aed",
"filename": "kickstart/files/kickstart.cfg",
"patchSetId": 5
},
"lineNbr": 3391,
"author": {
"id": 34119
},
"writtenOn": "2024-05-06T20:39:31Z",
"side": 1,
"message": "If I understand correctly, you are saying that \"if is_cloudinit_enabled is false: then \u003cdo steps relevant to task\u003e\". The choice of function name suggests the opposite, unless you actually read the code: \"if is_cloudinit_enabled returns 1; then do...\". It suggests that the subsequent steps are executed if cloudinit is enabled, which is not the case.\nI\u0027d still like a second opinion on the naming. The code is otherwise okay.",
"parentUuid": "96070a67_dc888a90",
"revId": "8c8f44fe009b70b01bfd1c3b77d9d3d938a219b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}