starlingx
/
metal
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
This commit is contained in:
Gerrit User 34119 2024-05-06 18:30:33 +00:00 committed by Gerrit Code Review
parent 692d3c8bf0
commit 6bbd220a65
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
8c8f44fe009b70b01bfd1c3b77d9d3d938a219b6
View File

@ -16,6 +16,23 @@
"message": "review votes removed with latest patchset which strictly updates Copyright header date.",
"revId": "8c8f44fe009b70b01bfd1c3b77d9d3d938a219b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d252bd3c_c9d80298",
"filename": "kickstart/files/kickstart.cfg",
"patchSetId": 5
},
"lineNbr": 3391,
"author": {
"id": 34119
},
"writtenOn": "2024-05-06T18:30:33Z",
"side": 1,
"message": "The statement above is somewhat misleading. The condition says \"if is_cloudinit_enabled\" but the statements below are for when cloudinit is NOT enabled.\nWhile the output of the function is_cloudinit_enabled ensures that the code below will be executed correctly, the name of the function should be changed to \"is_cloudinit_not_enabled\" for clarity.",
"revId": "8c8f44fe009b70b01bfd1c3b77d9d3d938a219b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}