starlingx/metal
Code Issues Proposed changes

Supress implicit-fallthrough warnings.

Browse Source 
In some parts of the mtce code some implicit fallthrough are used.
This causes a warning in the compiler and in OSes like openSUSE the
-Werror flag is enforced leading to a build error.

In this commit the __attribute__ ((fallthrough)) is used to tell the
compiler to not worry about this implicit fallthroughs as the it works
as intended.

Change-Id: I219ff9d490f3f86ad045e0f0e891f40467baaf06
Story: 2005862
Task: 33667
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
This commit is contained in:
Erich Cordoba 2019-06-17 13:08:06 -05:00
parent 2df0311b29
commit 717f285c64
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mtce/src/common/nodeClass.cpp
View File

@ -826,6 +826,7 @@ struct nodeLinkClass::node* nodeLinkClass::getEventBaseNode ( libEvent_enum requ
return ptr ; return ptr ;
} }
__attribute__ ((fallthrough));
} }
case VIM_HOST_DISABLED: case VIM_HOST_DISABLED:
case VIM_HOST_ENABLED: case VIM_HOST_ENABLED:
@ -839,6 +840,7 @@ struct nodeLinkClass::node* nodeLinkClass::getEventBaseNode ( libEvent_enum requ
return ptr ; return ptr ;
} }
__attribute__ ((fallthrough));
} }
case BARBICAN_GET_SECRET: case BARBICAN_GET_SECRET:
case BARBICAN_READ_SECRET: case BARBICAN_READ_SECRET:

4
mtce/src/maintenance/mtcNodeHdlrs.cpp
View File

@ -3232,6 +3232,7 @@ int nodeLinkClass::offline_handler ( struct nodeLinkClass::node * node_ptr )
node_ptr->offlineStage = MTC_OFFLINE__SEND_MTCALIVE ; node_ptr->offlineStage = MTC_OFFLINE__SEND_MTCALIVE ;
/* fall through on start */ /* fall through on start */
__attribute__ ((fallthrough));
} }
case MTC_OFFLINE__SEND_MTCALIVE: case MTC_OFFLINE__SEND_MTCALIVE:
{ {
@ -3870,6 +3871,7 @@ int nodeLinkClass::reset_handler ( struct nodeLinkClass::node * node_ptr )
} }
node_ptr->power_action_retries = MTC_RESET_ACTION_RETRY_COUNT ; node_ptr->power_action_retries = MTC_RESET_ACTION_RETRY_COUNT ;
/* the fall through is intentional */ /* the fall through is intentional */
__attribute__ ((fallthrough));
} }
case MTC_RESET__REQ_SEND: case MTC_RESET__REQ_SEND:
{ {
@ -4692,6 +4694,7 @@ int nodeLinkClass::power_handler ( struct nodeLinkClass::node * node_ptr )
node_ptr->power_action_retries = MTC_POWER_ACTION_RETRY_COUNT ; node_ptr->power_action_retries = MTC_POWER_ACTION_RETRY_COUNT ;
//the fall through to MTC_POWEROFF__REQ_SEND is intentional //the fall through to MTC_POWEROFF__REQ_SEND is intentional
__attribute__ ((fallthrough));
} }
case MTC_POWEROFF__REQ_SEND: case MTC_POWEROFF__REQ_SEND:
{ {
@ -4851,6 +4854,7 @@ int nodeLinkClass::power_handler ( struct nodeLinkClass::node * node_ptr )
node_ptr->power_action_retries = MTC_POWER_ACTION_RETRY_COUNT ; node_ptr->power_action_retries = MTC_POWER_ACTION_RETRY_COUNT ;
powerStageChange ( node_ptr , MTC_POWERON__POWER_STATUS ); powerStageChange ( node_ptr , MTC_POWERON__POWER_STATUS );
//the fall through to MTC_POWERON__REQ_SEND is intentional //the fall through to MTC_POWERON__REQ_SEND is intentional
__attribute__ ((fallthrough));
} }
case MTC_POWERON__POWER_STATUS: case MTC_POWERON__POWER_STATUS:
{ {