starlingx/metal
Code Issues Proposed changes

No json_object_put() for the json_obj created by json_object_object_get_ex().

Browse Source 
It is stated in the json_object.h from version 0.11:
https://github.com/json-c/json-c/blob/json-c-0.11/json_object.h#L271

As on json-c 0.11, there's no assert to check for the ref_count, we wont get
  crashed. But on json-c 0.13.1 (latest release), json_object_put will check
  for the ref_count first, so mtcAgent will crash.

Test Done:
Run mtcAgent with json-c version 0.13.1 with this patch, no crash found.

Closes-Bug: 1807097

Change-Id: I7f954c97804ae01f831c94a36b9dbdbb34dbf083
Signed-off-by: Yan Chen <yan.chen@intel.com>
This commit is contained in:
Yan Chen 2018-12-07 00:47:21 +08:00
parent b3eee43630
commit a92c543fd5
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mtce-common/src/common/jsonUtil.cpp
View File

@ -920,12 +920,6 @@ auth_load_cleanup:
} }
json_object_put(raw_obj); json_object_put(raw_obj);
} }
if (token_obj) json_object_put(token_obj);
if (svccat_obj) json_object_put(svccat_obj);
if (tuple_obj) json_object_put(tuple_obj);
if (end_obj) json_object_put(end_obj);
if (url_obj) json_object_put(type_obj);
if (type_obj) json_object_put(type_obj);
return (rc); return (rc);
} }